Repository navigation
Fix CI on main: Experiment timeout tests outlast a busy macOS runner - #1560
Merged
Merged
Conversation
The Bar's timeout also bounds code checks and the model Grader session. At one second, main's macOS shard timed out the fake Grader and the fake Trials themselves (run 40763918664). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JacobStephens2
added
the
test:macos
This was referenced Oct 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's CI went red on
test-macos-shard (4)(run 40763918664). Two tests intests/experimentsfailed:a_timeout_is_failed_even_after_repository_changes_and_its_descendants_endfailed withmodel Grader session failed.code_graders::check_timeout_cleans_descendants_before_packet_and_remains_failedhad Trials expected to succeed fail instead.The tests passed
--timeout 1. The Bar's timeout bounds the Trial sessions, but it also bounds code checks and the model Grader session. On a loaded macOS runner, the fake Grader'spython3and the fake Trial agent can each take more than a second.This PR adds a
SHORT_TIMEOUTof 4 seconds to the five tests that used 1 second. It also lengthens the sleeps those tests use to outlast the deadline:Fixes #1458. That issue's test,
timed_out_trials_keep_partial_usage_and_exportable_session_ancestry, also used--timeout 1. On macOS the deadline could cut the fake agent off before it emitted its partial usage line, soinput_tokenscame backNull.The PR has the
test:macoslabel so the full macOS suite runs on it.cargo nextest run --test experiments: 98 passed locally.🤖 Generated with Claude Code