Repository navigation
Score production samples with independent model Graders - #1277
Merged
Merged
Conversation
The Grader runs against a sampled repository, so the sandbox clears the ambient environment, copies logins instead of bind-mounting them, and hides Cargo registry credentials.
This was referenced Oct 24, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scores retain the Run's Built-with attribution, the Grader's Harness/Model and a local Command-record link when available. A blank Grader Model fails before launch because independence cannot be established. The new Session prompt and site documentation are regenerated.
Backports the model-session sandbox/proxy and Claude/Codex limit detection from #1014/#1008 on
main, whichissue-978does not yet contain. No Cargo dependency changes.Closes #1026
Evidence
cargo test --test scoring grading::an_unknown_default -- --nocapturefailed: an unspecified default Model was allowed to grade its own possible output.After: the same regression passes, requiring an explicit independent Model before launch.
cargo test --test scoring sandboxed_grader_cannot_read_ambient_secrets_or_replace_a_live_login -- --nocapturefailed with exit 101. The Grader read the operator's ambientRESEND_API_KEYand~/.cargo/credentials.toml, and replaced the live Codex login.After: the same test passes. The sandbox clears the environment, copies the login, and hides Cargo registry credentials. The operator's login file is unchanged. All 26 scoring integration tests pass, and
cargo clippy --all-targets -- -D warningspasses.RUST_TEST_THREADS=8 scripts/affected-tests issue-978passed: 43 site browser tests and the full Rust suite, including 1,256 unit tests and all 25 Scoring integration tests.cargo clippy --all-targets -- -D warningsand the prompt regeneration/check also passed. Affected-check wall time was 1,474.19 seconds, including browser tests and cached Rust compilation; nextest was unavailable, so the selector usedcargo test.Seams under test
scoreandscores --json.Review
.thirdshift-review-raUBY6/standards.mdand.thirdshift-review-raUBY6/spec.md, retained with the Session.Unaddressed findings
Standards
None. The single reported judgment was addressed.
Spec
None. No findings were skipped or deferred.
Security
None. The Grader sandbox isolation gap is fixed in
src/sandbox.rsand kept bysandboxed_grader_cannot_read_ambient_secrets_or_replace_a_live_login.Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
New optional Score fields preserve existing samples. Pending packets survive errors and plan-limit stops.
Blast Radius: scoring
Also backports shared process supervision and quota interpretation; ordinary Runs do not opt into plan-limit stopping. Production grading requires bwrap/socat and an explicit Model. Other Harnesses await verified warning protocols, as #1008 specifies.
Built with codex · gpt-6.1-sol · xhigh