Repository navigation
Spec: the Scoring run, which scores a weekly sample of production work - #1138
Merged
Merged
Conversation
Include Harness versions in Built-with attribution
Unify Built-with attribution so Scoring retains detected Harness versions while accepting legacy lines. Preserve the shared marker, formatter and reader, and verify the factory-to-Scoring version round trip.
Add Scoring runs and weekly factory PR samples
Build blind packets for sampled pull requests
The Grader runs against a sampled repository, so the sandbox clears the ambient environment, copies logins instead of bind-mounting them, and hides Cargo registry credentials.
A Bug-origin session can replace proposal.json with a symlink. Scoring read that path on the host after the sandbox exited, so the link could import a host file into the saved proposal or block on a fifo while the machine-wide Scoring lock was held. The model Grader read scores.json the same way. Both reads now accept only a regular file with one name and a bounded size.
Score production samples with independent model Graders
Combine production Grader checkpoints and carry-over with Bug-origin proposals. Preserve newer process supervision, native quota observation, Session traces and bounded session-output reads. Retain the incoming sandbox secret isolation, explicitly publish private Grader packet paths, and scope the Scoring fake-launcher override so Experiment and Trial checks still exercise real sandboxes. Regenerate prompts and documentation and retain a combined origin/Grader resume regression. Validation: formatting and clippy pass; all 50 site checks and all Rust test targets pass across the affected-test run and completion run. The release-resume and worker-overlap Experiment tests each passed exact reruns after intermittent failures during parallel runs.
Add your Scores and criterion calibration
# Conflicts: # README.md # docs/code-navigation.md # docs/guide.md # site/architecture/index.html # site/docs/index.html # site/how-it-works/index.html # site/index.html # src/main.rs # src/sandbox.rs # src/scoring.rs
Propose Bug origins for closed bugs during Scoring
Confirmation checked the introducing pull request, so a proposal saved before that label still wrote a code-review Eval task. It now reads the bug's current labels and leaves the proposal unsettled.
Settle Bug origins and propose code-review Eval tasks
Add Scores and Bug origins pages to the Console
JacobStephens2
marked this pull request as ready for review
October 25, 2026 05:33
Preserve Scoring's private-session runner and bounded output reads while adopting upstream scoped process supervision and Recording-owned Interpretation. Keep blind Scoring stream-only through an explicit recording policy, retaining native quota handling and upstream memory-cap regressions. Preserve Scoring site guidance alongside updated Trial repository preparation documentation. Validation: cargo check --all-targets; cargo clippy --all-targets -- -D warnings; cargo fmt --check; 25 recording tests; 3 model-Grader tests; 35 active Scoring integration tests; scripts/affected-tests main (50 site checks and full Rust suite, 2059.60 seconds including cached compilation).
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the whole Scoring Spec, including all eight Tickets. Weekly Scoring runs sample merged factory pull requests across configured owners, grade them independently, and propose Bug origins for closed bugs.
Scoring keeps its Command record, Inbox and Stop behavior, resumes pending packets after plan-limit stops, excludes Security fixes, and retains private evidence locally. The first run adds 20 historical calibration pull requests and backfills closed bugs; later samples mark two pull requests for human scoring. Proposed Eval tasks require separate approval.
Closes #978
Evidence
scores 23 --mine --jsonaction and model Score disclosure from an ordinaryscoresread. Both new whole-binary regressions failed before their fixes.After: both commands pass. Human entry returns valid JSON after saving all five Scores; list/detail reads in text and JSON withhold model Scores until human Scores exist. Calibration still reads the stored assessments before filtering the public view.
/usr/bin/time -p scripts/affected-tests mainpassed: all 50 public-site browser tests and the full Rust suite (cargo testfallback; nextest unavailable). Whole selection wall time: 1513.63s (25m 14s), including 1m 24s of Rust compilation with cached dependencies. This is local execution time, not CI queue time.Seams under test: the whole binary against fake GitHub and Harnesses, its retained private scoring folder and Command records, CLI text/JSON and terminal entry, and the Console's HTTP and browser interfaces. Built-with reader/writer coverage uses existing pull-request and factory-run tests.
Unaddressed findings
Standards
adapter.session, Command-linkedRecording::capture, stream-only interpretation, explicit plan-limit stopping and sandbox startup diagnosis. Private runner, lines 43–98 usesadapter.trial_session, capped scoped commands,Recording::for_trial, private stderr/scope artifacts and a deadline. Both already share sandbox and recording modules; combining their orchestration would add policy options for these different contracts. No behavior failure or documented-standard breach was claimed for this heuristic.Spec
None. The blind-scoring finding was reproduced and fixed. A provisional historical base-reference concern was withdrawn after a read-only GraphQL check of merged PR #1139: its
baseRefOid(9ab1273) still equals the merge commit's first parent, althoughissue-978has advanced tod305b7e.Security
None.
Security review outcome
No unaddressed introduced findings.
Review coverage
Independent Standards and Spec reviews read all 98 changed paths since
main, then both re-read all 14 paths changed by the review fixes. No changed file remains unread on either axis. Generated prompt and manual outputs were inspected directly; no generated files were excluded. Final reports with each axis's files-read list are retained as Session evidence in.thirdshift-review-eE0h5j/standards.mdand.thirdshift-review-eE0h5j/spec.md.Merge Danger
Door: Two-way.
Code can be reverted; retained private samples, judgments and proposed Eval tasks remain on the host. Weekly scheduling and initial human calibration are Day-shift steps.
Blast Radius: Factory.
Shared changes also touch Built-with attribution, sandbox sessions, Command recording and Console navigation.
Built with codex · gpt-6.1-sol · xhigh
Tickets
thirdshift score: the Scoring run and its weekly sample #1024 done