Skip to content

chore: pin the Node version for contributors - #342

Merged
IanoNjuguna merged 1 commit into
IntersectMBO:mainfrom
Kshot3000:chore/pin-node-version
Oct 18, 2026
Merged

IanoNjuguna merged 1 commit into
IntersectMBO:mainfrom
Kshot3000:chore/pin-node-version

Conversation

@Kshot3000

Copy link
Copy Markdown
Contributor

Fixes #340.

Nothing pinned the Node version for contributors: the workflows run Node 22 and website/package.json requires >=22.12.0, but there was no version file in the repo, and the prerequisites in CONTRIBUTING.md still said "Node.js (v16 or higher)" — so two shells on the same machine could run npm ci under different majors against the same lockfile and get different behaviour, which is what made #336 harder to debug.

This change is the two files the issue scopes, and nothing else:

  • .nvmrc at the repository root containing 22, matching node-version: 22 in the workflows. Contributors using nvm or fnm get the right runtime with nvm use / fnm use, without having to read the workflows.
  • CONTRIBUTING.md prerequisites now say Node.js 22 (v22.12.0 or higher, matching engines in website/package.json) and point at the .nvmrc.

Acceptance criteria from #340:

  • A Node version file exists at the root and matches the workflows — .nvmrc = 22; every workflow pins node-version: 22 (verified by grepping .github/workflows/ on current main).
  • CONTRIBUTING.md prerequisites match engines — prerequisites now state >=22.12.0, the exact floor in website/package.json.

No build change: no source, workflow, or manifest file is touched.


@Kshot9000 (https://x.com/kshot9000) · ADA: addr1q8hnl6vl5a6k3rw3n5g3jtte696zcl76kfatzv7gpswa9r0dj7fma6klq55y4ffm7tf0em09udnyhuk4ah92pl5x9jpqjae44v
Independent builder — not affiliated with the Cardano Foundation, IOG or Intersect. cc @cardano-foundation @IntersectMBO

Adds .nvmrc (22) at the repository root, matching the workflows'
node-version: 22 and the engines floor in website/package.json
(>=22.12.0), and updates the CONTRIBUTING.md prerequisites, which
still said Node.js v16 or higher, to name Node 22 and the .nvmrc so
nvm/fnm users get the right runtime without reading the workflows.

Closes IntersectMBO#340

@IanoNjuguna IanoNjuguna left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, that was fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pin the Node version for contributors

2 participants