Repository navigation
chore: pin the Node version for contributors - #342
Merged
Merged
Conversation
Adds .nvmrc (22) at the repository root, matching the workflows' node-version: 22 and the engines floor in website/package.json (>=22.12.0), and updates the CONTRIBUTING.md prerequisites, which still said Node.js v16 or higher, to name Node 22 and the .nvmrc so nvm/fnm users get the right runtime without reading the workflows. Closes IntersectMBO#340
Kshot3000
requested review from
IanoNjuguna,
Ranchhand87 and
danbaruka
as code owners
October 18, 2026 09:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #340.
Nothing pinned the Node version for contributors: the workflows run Node 22 and
website/package.jsonrequires>=22.12.0, but there was no version file in the repo, and the prerequisites inCONTRIBUTING.mdstill said "Node.js (v16 or higher)" — so two shells on the same machine could runnpm ciunder different majors against the same lockfile and get different behaviour, which is what made #336 harder to debug.This change is the two files the issue scopes, and nothing else:
.nvmrcat the repository root containing22, matchingnode-version: 22in the workflows. Contributors using nvm or fnm get the right runtime withnvm use/fnm use, without having to read the workflows.CONTRIBUTING.mdprerequisites now say Node.js 22 (v22.12.0 or higher, matchingenginesinwebsite/package.json) and point at the.nvmrc.Acceptance criteria from #340:
.nvmrc=22; every workflow pinsnode-version: 22(verified by grepping.github/workflows/on currentmain).CONTRIBUTING.mdprerequisites matchengines— prerequisites now state>=22.12.0, the exact floor inwebsite/package.json.No build change: no source, workflow, or manifest file is touched.
@Kshot9000 (https://x.com/kshot9000) · ADA: addr1q8hnl6vl5a6k3rw3n5g3jtte696zcl76kfatzv7gpswa9r0dj7fma6klq55y4ffm7tf0em09udnyhuk4ah92pl5x9jpqjae44v
Independent builder — not affiliated with the Cardano Foundation, IOG or Intersect. cc @cardano-foundation @IntersectMBO