Repository navigation
fix: remove the docs feedback widget - #336
Merged
IanoNjuguna merged 4 commits intoOct 18, 2026
Merged
Conversation
The form always reported success, including when no script URL was configured, and it posted visitor text to a public Apps Script.
Stop passing GOOGLE_SCRIPT_URL into the site build and delete the script that appended visitor text to the Sheet.
The dependabot merges for dotenv (IntersectMBO#317) and mermaid (IntersectMBO#318) bumped package.json without regenerating package-lock.json, so every npm ci run fails with EUSAGE before the build starts: the lock still pins dotenv 17.3.1 and mermaid 11.17.2. The PR build gate and the Pages deploy have both been red on main since 2026-10-16. Regenerated with npm install against the current package.json, which resolves dotenv 18.0.8, mermaid 12.2.0 and @mermaid-js/parser 2.0.1.
mermaid 12 declares engines node >=22.12.0, but both workflows pinned Node 20, so npm ci installs it with EBADENGINE warnings and the build runs on a runtime the library does not support. Bump the PR gate and the Pages deploy to Node 22 and raise the package engines floor to match. Docusaurus itself is unaffected (engines >=20.0).
IanoNjuguna
self-requested a review
October 18, 2026 07:01
IanoNjuguna
approved these changes
Oct 18, 2026
This was referenced Oct 18, 2026
2 tasks done
IanoNjuguna
added a commit
that referenced
this pull request
Oct 18, 2026
Nothing pinned the runtime. Both workflows that set up Node use 22, and `website/package.json` requires >=22.12.0, but the repo had no version file and `CONTRIBUTING.md` still said "Node.js (v16 or higher)". Two shells on the same machine could then run `npm ci` under different majors against the same lockfile, which is part of what made #336 awkward to debug. Add `.nvmrc` at the root containing 22, so `nvm` use or `fnm` use selects the major the workflows already run, and update the CONTRIBUTING prerequisites to state Node 22 with the 22.12.0 engines floor and point at the file. No source, workflow or manifest change: `.nvmrc` is read by version managers only, and nothing in CI depends on it. Closes #340
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The docs footer asked "Was this helpful?" and posted the page URL, vote, comment, and user agent to a public Google Apps Script. That script appended the values straight into a Google Sheet. A cell that starts with
=is a formula, so a visitor could store a formula in the Intersect sheet.The widget also showed success when the script URL was missing, so we cannot treat it as a working collection channel. This PR removes the widget, the script template, and the build secret wiring.
Related Issue
Related to the private GHSA on formula injection in the feedback Apps Script.
Type of Change
Changes Made
website/src/components/FeedbackWidgetand the doc-footer swizzle that mounted it.website/src/css/custom.css.website/google-apps-script.js.customFields.googleScriptUrland theGOOGLE_SCRIPT_URLenv var from the Pages deploy workflow.After merge, please:
GOOGLE_SCRIPT_URLActions secret.=and clear any that are not real feedback.Checklist
mainormasterbranch.