Repository navigation
feat(skilleval): fixed manual historical cloud generation job - #269
Conversation
Freeze reviewed main inputs before existing-secret injection; preserve separate historical accounting and secret-free replay. Keep the fixed two-request budget and refuse retries or runtime scope changes. Signed-off-by: Codex <codex@openai.com> Agent-assisted-by: Codex design_cloud_trial253 (implementation) Agent-assisted-by: Codex verify_trial_cost_bounds (audited configuration)
Skill evaluationAutomatic execution / cumulative PR budget: Advisory: obtain missing evidenceRetained evidence availability: planned / unexecuted. No approval or merge authorization is issued.
PLANNED: execution is not authorized by knowing this hash. Selected comparisons: 0 · Estimated task calls: 0. Applicable only while these revisions and inputs match the current PR. Plan bindings, budget, frozen exam and advisory detailsUnchanged-correct is valid neutral evidence, not incremental benefit. Per-case outcomes (discovery excluded; regressions and gaps first): []Showing at most 20 of 0 pairs; the evidence link contains all outcomes, including omitted regressions/gaps. Plan SHA-256: Model/settings:
Provider/settings: Uncovered / unsupported paths (9)
|
Signed-off-by: Codex <codex@openai.com> Agent-assisted-by: Codex design_cloud_trial253 (metadata)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 961731057e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| a1ee3266466194c16f4e2159ab845b758ed9561b \ | ||
| 86f003364804d116b3202c4d807cc898a3a02ade |
There was a problem hiding this comment.
Keep historical campaign revisions out of shared automation
The workflow commits the actual baseline and candidate campaign SHAs directly into its fetch command, with the same campaign pins duplicated in the new controller and policy. The root AGENTS.md explicitly requires campaign revisions to remain issue-scoped and forbids committing real campaign SHAs into workflows. Move these revisions into an issue-scoped, reviewed authorization artifact and have the trusted preparation path validate that artifact, preserving the existing authorization boundary without embedding this experiment in shared automation.
AGENTS.md reference: AGENTS.md:L54-L58
Useful? React with 👍 / 👎.
Keep campaign revisions, identifiers and limits in the acceptance Issue. Validate the reviewed comment identity and exact bytes before preparation, reservation and every provider grant; shared automation retains no campaign source pins. Signed-off-by: Codex <codex@openai.com> Agent-assisted-by: Codex design_cloud_trial253 (implementation)
Dong1017
left a comment
There was a problem hiding this comment.
Scoped software LGTM at 9fec28e / tree bf2fc3880768c6c453e862b31c5fc658f8a400a8, base f93df05.
P1 disposition for discussion_r4421672934: fixed and verified, not dismissed. Real historical revisions, experiment ID and numeric limits now reside in the issue-scoped record #253 (comment). Shared workflow/controller no longer embed those campaign pins; the former shared policy is removed. Main retains only the exact Issue/comment/author/full-body digest locator. Independent readback hashes the actual comment to ea6493151023f6167c833ad2099838c867d3d7548a612a7cc0b8769bb26fec4c. Fixed-API, strict schema/duplicate-key checks, no redirects, validated Git arguments, and revalidation before reservation plus every broker grant preserve the authorization boundary.
Verification: 70 corrective focused tests independently passed and Ruff passed; a no-key/no-model/no-ledger-write smoke fetched the actual Issue record and prepared the historical inputs successfully. Current-head Ready CI 41026464012 succeeded; native review 6518229123 completed on this head with no unresolved findings. Prior P1 is explicitly reconciled above. No other unresolved opinions identified.
This approves software readiness only, not efficacy or a completed trial. The manual main-only job still requires current Issue authorization, effective-rate validity, credential presence, successful qualification and durable budget admission. Generated code is never executed in the credential-bearing generation step, and the independent replay remains credential-free. No paid model call has run yet. Existing generic PR SkillEval advisory remains zero-comparison/unexecuted and is not used as evidence of benefit. #253 remains open. COMMENT, not a formal APPROVE.
Governing Issue and delivery slice
Refs #253. Follow-up deployment for merged #267; no actual comparison result or Issue completion is claimed.
Operational configuration
9c53ce5f5f40b4765d64847e66c552d4857108e9; existing daily ledger ancestry is retained without reset or new reservation in this PR.6518412099, owner author and complete body SHA256ea6493151023f6167c833ad2099838c867d3d7548a612a7cc0b8769bb26fec4c; it is rechecked before reservation and every provider grant.Checks and dependencies
1287fe75ca98179460c5e123f4b4a4e19374928d; final reviewed metadata-only tree:a6d24a924bb92b046f02c0edd431cfa8d2d1d54e; basef93df0548a26714f6514337a8525c7c14108acad(feat(skilleval): bounded cloud generation and isolated artifact replay #267).Knowledge authorship declaration
Agent-assisted code/workflow/operational configuration only; no protected skill or knowledge asset edits. Model identifiers are not asserted.
Remaining work
After exact-head review and passing normal CI, merge the bounded job, freeze final main inputs, perform durable admission and the two real captures, then independently replay and report the measured outcome. A negative or inconclusive result remains valid evidence; neither this software PR nor green CI closes #253.
Native-review correction pending final verification
P1 discussion_r4421672934 is addressed in proposed head
9fec28e4de261537757bdb4747566f7473a384c8(treebf2fc3880768c6c453e862b31c5fc658f8a400a8): campaign pins/defaults moved to the acceptance Issue; strict fixed-endpoint/author/issue/full-body-hash/duplicate-key validation and argv-only Git fetch preserve the trust boundary. The old in-tree campaign policy is deleted. New synthetic-fixture and revocation-before-reservation tests are added. After the separate CPU measurement completed, the corrective delta passed 70 local tests (job/accounting/generation) and Ruff. A real public-comment preflight fetched and verified the pinned issue record, fetched only validated historical Git objects, and prepared the frozen plan with the provider key removed; no model call or ledger write occurred. Current-head remote CI and review remain required before merge; no substantive review thread has been resolved by this update.