Repository navigation
feat(skilleval): bounded cloud generation and isolated artifact replay - #267
Conversation
Retain generation-only parser artifacts, bind historical experiment accounting separately from compared revisions, and replay fixed data-only bundles on qualified Linux hosts. Preserve original inconclusive captures and report independent artifact checks separately. Signed-off-by: Codex <codex@openai.com> Agent-assisted-by: Codex design_cloud_trial253 (implementation) Agent-assisted-by: Codex verify_trial_cost_bounds (accounting implementation) Agent-assisted-by: Codex find_skilleval_unblock (replay implementation)
Skill evaluationAutomatic execution / cumulative PR budget: Advisory: obtain missing evidenceRetained evidence availability: planned / unexecuted. No approval or merge authorization is issued.
PLANNED: execution is not authorized by knowing this hash. Selected comparisons: 0 · Estimated task calls: 0. Applicable only while these revisions and inputs match the current PR. Plan bindings, budget, frozen exam and advisory detailsUnchanged-correct is valid neutral evidence, not incremental benefit. Per-case outcomes (discovery excluded; regressions and gaps first): []Showing at most 20 of 0 pairs; the evidence link contains all outcomes, including omitted regressions/gaps. Plan SHA-256: Model/settings:
Provider/settings: Uncovered / unsupported paths (13)
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Keep both capture and capture-report phases inert on every host. Preserve explicit deferred verification and independently replay only in the verifier phase. Signed-off-by: Codex <codex@openai.com> Agent-assisted-by: Codex design_cloud_trial253 (implementation)
Dong1017
left a comment
There was a problem hiding this comment.
Scoped software LGTM at f77f735 / tree c194a5219f24375f14609ca051cd9616c8fddcb9, base 37166b6. The PR body retains its initial tree/test snapshot; this review covers the final published tree, including the later no-execution-in-generation correction.
Independent review verified generation capture and its automatic report never invoke artifact verification even on a capable host; only the separate trusted replay path runs parsers. Replay preserves original deferred provenance, uses bounded strict JSON plus exact revision/hash bindings, and requalifies the same host with good/bad controls. Existing 19-check grading remains unchanged. Historical accounting separates charge PR from skill revisions, binds full approval digest and stable experiment identity, preserves previous reservations, and retains per-request dual-ledger/CAS guards with no retry/refund. Earlier integration findings (deferred replay eligibility, integrity error precedence, export binding, and ledger plan digest) are fixed with regressions.
Verification: independent 60 focused tests passed; final implementation regression run 192 tests and Ruff passed. Current-head Ready CI 41017811917 and policy checks passed. Native review 6516945855 completed on this head without findings; no unresolved review objections identified.
Advisory 6516942992 remains zero-comparison/unexecuted, not efficacy evidence. This is software infrastructure delivery only. Actual model execution still requires valid effective pricing, approved operational configuration and accounting, and authorized credential access. No new credential-consuming job is included here. Hosted qualification of the earlier verifier is not blanket approval of this changed tree; replay requalifies before evaluating artifacts. No real paired result or #253 acceptance is claimed. COMMENT only, not formal APPROVE.
Governing Issue and delivery slice
Refs #253
parser.pybytes. This is not an iterative coding-agent experiment.Changed artifacts and evidence
tools/skill_eval_historical_accounting.pytools/skill_eval_cloud_replay.py, manual workflowtools/skill_eval_cloud_export.pyChecks and dependencies
git diff --checkPASS.37166b6f7323c76a091e423a7163ac99c4ae01ac.4504542c565e66e1a1fde432e8dc36ae163f522d; published head has the identical tree.Knowledge authorship declaration
Code/workflow/operational docs only; no protected skill or knowledge asset changes. Material implementation is agent-assisted; model identifiers are not asserted here.
Remaining work and Issue closure
Keep #253 open. After current-head review/CI: verify actual Linux qualification, freeze the precise prospective protocol and fresh cost/accounting inputs, capture the bounded pair, export its source bytes, independently replay, and publish the measured result with limits. A negative or inconclusive result must remain truthful. This PR is software delivery, not completion of the experiment.