Repository navigation
docs(deploy): document understudy-prod RBAC is actuator-consumed - #9
Merged
Harikeshav-R merged 1 commit intoSep 11, 2026
Merged
Conversation
deploy/policies/understudy-prod.yaml grants a ServiceAccount access to patch Deployments/ConfigMaps in ust-prod, but no Deployment in deploy/prod/*.yaml sets serviceAccountName: understudy-prod. A code-review pass against PR #6 flagged this as a dead grant. It is not dead: per ADR-028 (docs/01-decisions.md), the actuator authenticates to the Kubernetes API directly as this ServiceAccount from the agent host process (docs/02-architecture.md §2.10), not by being assumed as pod identity. This RBAC ships ahead of its consumer (build-plan step A1.7 landed; actuator/apply.py is step 5.1/5.2, still unbuilt per CHECKLIST.md). Document that explicitly so it is not re-flagged as dead code before Phase 5 lands. Implements build-plan step A1.7 (documentation follow-up). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CzBeBUsZmE38K1kWeLMhNh
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build-Plan Step Implemented
Checkpoint Execution & Output
Note:
tests/unit/services/was excluded from the coverage run above becausetest_edge_gateway.pytriggers a pre-existing Windows-only crash (OpenSSLUplink conflict between psycopg-binary and httpx) on this local dev machine,
unrelated to this change (this PR touches only
deploy/policies/anddocs/). CI runs onubuntu-latest(.github/workflows/ci.yml), where thisdoes not reproduce.
ADRs Relied On
Kubernetes API as a scoped ServiceAccount; this PR documents that
understudy-prodis that ServiceAccount and clarifies it is consumeddirectly by the actuator, not via pod identity.
Mock Registry Disclosures
Documentation Updates
docs/02-architecture.md: added a note next to the package-boundary tablecross-referencing
deploy/policies/understudy-prod.yamland explaining whyit is currently unreferenced by any Deployment.
Definition of Done
make checkgreen (see checkpoint output above; services/ tests excluded for the Windows-local reason noted, not related to this change)# MOCKED:marker without a row in docs/MOCKS.mdContext
A
/code-reviewpass against PR #6 flaggeddeploy/policies/understudy-prod.yaml'sServiceAccount/Role/RoleBinding as a "dead RBAC grant" since no
deploy/prod/*.yamlDeployment setsserviceAccountName: understudy-prod.Investigation found this is intentional, forward-looking infrastructure —
ADR-028 says the actuator (a host process outside the cluster, per
docs/02-architecture.md §2.10) authenticates to the Kubernetes API as this
ServiceAccount directly, not via pod identity, and the actuator itself
(build-plan step 5.1/5.2) hasn't been built yet. This PR documents that
reasoning inline so the grant isn't mistaken for dead code again before
Phase 5 lands.
Base branch is
feat/policies-and-loadgen(PR #6, still open) rather thanmain, sincedeploy/policies/only exists on that branch's stack.🤖 Generated with Claude Code
https://claude.ai/code/session_01CzBeBUsZmE38K1kWeLMhNh