Repository navigation
fix(deploy): wire FAULT_INJECTION_SEED from ConfigMap; document deferred flags - #10
Closed
rsanghvi21 wants to merge 1 commit into
Closed
rsanghvi21 wants to merge 1 commit into
rsanghvi21 wants to merge 1 commit into
Conversation
…red flags deploy/prod/configmap.yaml's app-config.FAULT_INJECTION_SEED (1337) exactly matches services/_common/faults.py's hardcoded DEFAULT_FAULT_INJECTION_SEED, but nothing wired the ConfigMap value in -- every service silently fell back to the code default. A code-review pass against PR #6 flagged this as a dead ConfigMap key. Wire FAULT_INJECTION_SEED into all four deploy/prod/*.yaml Deployments via configMapKeyRef so the ConfigMap is the actual source of truth in prod, with the code constant remaining only as the non-k8s/local fallback. feature-flags and app-config's ENVIRONMENT/LOG_LEVEL stay unwired: docs/02-architecture.md §2.5 requires feature flags to be read live at request time, not from a startup env var, which needs the actuator's not-yet-built DISABLE_FLAG/REVERT_CONFIG live-read mechanism (Phase 5). Document that explicitly in the ConfigMap so it is not re-flagged as dead configuration before Phase 5 lands. Implements build-plan step A1.7/A1.8 (fix + documentation follow-up). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CzBeBUsZmE38K1kWeLMhNh
Harikeshav-R
added a commit
that referenced
this pull request
Sep 11, 2026
Owner
|
Closed as integrated into main via PR #6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build-Plan Step Implemented
Checkpoint Execution & Output
test_edge_gateway.pyandtest_loadgen.pyare excluded above because bothconstruct a real
httpx.AsyncClient, which triggers a pre-existingWindows-local-only crash (OpenSSL Uplink conflict between psycopg-binary and
httpx) on this dev machine -- unrelated to this change. CI runs on
ubuntu-latest(.github/workflows/ci.yml), where this does not reproduce.ADRs Relied On
prod source of truth explicit without changing the seeding mechanism.
Mock Registry Disclosures
Documentation Updates
docs/02-architecture.md§2.5: noted thatFAULT_INJECTION_SEEDis sourcedfrom the
app-configConfigMap indeploy/prod, with the code constant asfallback only.
deploy/prod/configmap.yaml: added comments explaining whyfeature-flagsand
ENVIRONMENT/LOG_LEVELremain unwired (await the Phase 5 live-readmechanism), so they read as intentional, not a leftover fix.
Definition of Done
make checkgreen (see checkpoint output; two pre-existing Windows-local-only hanging test files excluded, unrelated to this change)# MOCKED:marker without a row in docs/MOCKS.mdContext
A
/code-reviewpass against PR #6 flaggeddeploy/prod/configmap.yaml's twoConfigMaps as unreferenced by any Deployment. Investigation found
FAULT_INJECTION_SEED(1337) exactly matchesservices/_common/faults.py's hardcoded default -- a real, fixable gap -- sothis PR wires it into all four Deployments via
configMapKeyRef. Theremaining keys (
feature-flags,ENVIRONMENT,LOG_LEVEL) genuinely can'tbe wired the same way yet:
docs/02-architecture.md§2.5 requires featureflags to be read live at request time, which needs the not-yet-built Phase 5
actuator. Both cases are now documented inline so they aren't re-flagged as
dead configuration.
Base branch is
feat/policies-and-loadgen(PR #6, still open), sincedeploy/prod/only exists on that branch's stack. Builds on#9 (docs/rbac-actuator-consumed), same underlying pattern.
🤖 Generated with Claude Code
https://claude.ai/code/session_01CzBeBUsZmE38K1kWeLMhNh