Repository navigation
Conversation
alixhami
added
the
do not merge
googlebot
added
the
cla: yes
995861d to
b07e410
Compare
b07e410 to
02c593c
Compare
|
|
||
|
|
||
| def inspect_image_file(project_id='YOUR_PROJECT_ID', | ||
| filepath='path/to/image.png'): |
There was a problem hiding this comment.
No hanging indents, please.
If you really wanna be clever run it through black.
There was a problem hiding this comment.
Surprisingly, black wanted me to just have a long line that violates the 79 characters rule, so I didn't follow it. Fixed indentation in a8d248c.
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| inspect_image_file(project_id=sys.argv[1], filepath=sys.argv[2]) |
There was a problem hiding this comment.
This is really less than ideal, as if the user tries to run without arguments this they will get a really unhelpful error.
|
Please address requested changes if this PR is still desired. |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
googlebot
added
cla: no
|
@alixhami Reopen if still relevant, otherwise, closing. |
|
With the format guidelines updated in #2565 this feels obsolete. Ok to close? |
|
Let's close this. Feel free to reopen. |
Proposed template for auto generated Python samples.
See more details in the Node.js PR description.