Skip to content

Create sample format guidelines for Python-docs-samples #2565

Closed

Description

@nnegrey

The python reviewer group required to approve PRs has only 4 people, be nice to expand that quickly.
Also probably having a canonical sample in Python that is agreed upon would be nice too! (To protobuf or to dictionary that is the question, I vote protobuf objects)

Activity

  1. leahecole commented on Nov 20, 2019

    @leahecole
    Collaborator

    Agreed re the group. It won't just be the 4 of us forever, but might be through Thanksgiving at least.

    For canonical sample, also agreed! In fact, we actually have had a PR open for awhile regarding this, and it's something that is in the backlog. #1756

  2. nnegrey commented on Nov 20, 2019

    @nnegrey
    ContributorAuthor

    Yea, wasn't sure if Alix's sample was still the most up to date.

  3. added
    type: processA process-related concern. May include testing, release, or the like.
    on Nov 22, 2019
  4. andrewferlitsch commented on Dec 3, 2019

    @andrewferlitsch
    Contributor

    @nnegrey. This seems to be about internal process (not issue). Can we close this?

  5. nnegrey commented on Dec 3, 2019

    @nnegrey
    ContributorAuthor

    No, I'd prefer this is left open until resolved.

  6. changed the title [-]Expand number of Python Reviewers[/-] [+]Create sample format guidelines for Python-docs-samples[/+] on Dec 4, 2019
  7. kurtisvg commented on Dec 4, 2019

    @kurtisvg
    Contributor

    Reassigning this to Doug, since he volunteered to write a sample format guide similar to Java's.

    If anyone else is interested in becoming a python-samples-owner, let me know and I'll loop you in on the meeting.

  8. andrewferlitsch commented on Mar 17, 2020

    @andrewferlitsch
    Contributor
  9. leahecole commented on Apr 2, 2020

    @leahecole
    Collaborator

    This is still ongoing and being talked about behind the scenes. #2728 is in progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

type: processA process-related concern. May include testing, release, or the like.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions