You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Create sample format guidelines for Python-docs-samples #2565
The python reviewer group required to approve PRs has only 4 people, be nice to expand that quickly.
Also probably having a canonical sample in Python that is agreed upon would be nice too! (To protobuf or to dictionary that is the question, I vote protobuf objects)
Activity
leahecole commentedon Nov 20, 2019
Agreed re the group. It won't just be the 4 of us forever, but might be through Thanksgiving at least.
For canonical sample, also agreed! In fact, we actually have had a PR open for awhile regarding this, and it's something that is in the backlog. #1756
nnegrey commentedon Nov 20, 2019
Yea, wasn't sure if Alix's sample was still the most up to date.
andrewferlitsch commentedon Dec 3, 2019
@nnegrey. This seems to be about internal process (not issue). Can we close this?
nnegrey commentedon Dec 3, 2019
No, I'd prefer this is left open until resolved.
[-]Expand number of Python Reviewers[/-][+]Create sample format guidelines for Python-docs-samples[/+]kurtisvg commentedon Dec 4, 2019
Reassigning this to Doug, since he volunteered to write a sample format guide similar to Java's.
If anyone else is interested in becoming a python-samples-owner, let me know and I'll loop you in on the meeting.
andrewferlitsch commentedon Mar 17, 2020
@dmahugh PTAL
leahecole commentedon Apr 2, 2020
This is still ongoing and being talked about behind the scenes. #2728 is in progress