Repository navigation
Tidy the two #223 citations - #225
Merged
Merged
Conversation
Both were awkward as written. "cannot fire for any input, which is #223" left the issue reference hanging off the sentence as a fragment, and "what would arm it, and that is #223" put the link on its own line, separated from the clause it belonged to. Neither said anything wrong; they just read badly at the two places somebody lands when they want to know why a panel is empty. Reported by Copilot on #224. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
Changes are limited to wording in documentation/dashboard text and appear consistent, valid, and non-functional.
Pull request overview
Refines wording around issue #223 references in the security observability docs/dashboard so the “empty panel” caveats read as complete sentences without changing meaning or behavior.
Changes:
File summaries
| File | Description |
|---|---|
| stacks/observability/grafana/dashboards/security-overview.json | Adjusts the markdown caveat panel wording for the #223 reference. |
| docs/observability.md | Rephrases the #223 citation sentence for clearer reading flow. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #224, which had already merged when the review landed.
Two wording fixes, no change in meaning:
security-overview.json— the caveat panel read "cannot fire for any input, which is TerminalSegmentReachedInternalNetwork cannot fire — the firewall logs blocks only #223", leaving the issue reference hanging off the sentence as a fragment. Now: "cannot fire for any input. That is tracked in TerminalSegmentReachedInternalNetwork cannot fire — the firewall logs blocks only #223: enabling pass logging on the inter-VLAN rules is what would make that alert, and the red series below, capable of saying anything."docs/observability.md— read "…is what would arm it, and that is" with the link stranded on the following line. Now a single clause: "Arming it means enabling logging on the inter-VLAN pass rules in pfSense, which is tracked in TerminalSegmentReachedInternalNetwork cannot fire — the firewall logs blocks only #223."Neither said anything wrong. They just read badly at the two places somebody lands when they want to know why a panel is empty, which is the whole job of that text.
make validatepasses: 7 dashboards, 140 panels, 132 PromQL and 28 LogQL expressions,docs OK.🤖 Generated with Claude Code