Repository navigation
Track the dead segmentation alert as #223 - #224
Merged
Merged
Conversation
#223 records that TerminalSegmentReachedInternalNetwork cannot fire — the firewall logs blocks only and the rule matches action="pass". The finding was already written down in observability.md and stated on the dashboard, but neither pointed at an issue, and roadmap.md did not list it at all. That is the gap this repository keeps rediscovering from the other direction: a known problem described in prose with nothing tracking it reads, six months later, as a thing somebody decided was fine. The dashboard's caveat panel now cites #223 the way it already cites #89 for the unwatched VLANs and #90 for detecting Suricata dying. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
Changes are limited to documentation/caveat text updates that align with the PR description and do not introduce behavioral risk.
Pull request overview
This PR adds explicit issue tracking for the known “dead” Loki alert TerminalSegmentReachedInternalNetwork by referencing issue #223 in the roadmap, observability documentation, and the security overview dashboard’s caveats.
Changes:
File summaries
| File | Description |
|---|---|
| stacks/observability/grafana/dashboards/security-overview.json | Adds a #223 citation in the dashboard caveat explaining why the pass-based alert cannot fire. |
| docs/roadmap.md | Lists #223 in the Security roadmap section as tracked open work. |
| docs/observability.md | Links the documented “cannot fire” finding to issue #223. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #82 and #223.
#223 records that
TerminalSegmentReachedInternalNetworkcannot fire — the firewall logs blocks only, and the rule matchesaction="pass". The finding was already written down indocs/observability.mdand stated on thehomelab-securitydashboard, but neither pointed at an issue, anddocs/roadmap.mddid not list it at all.That is this repository's recurring failure seen from the other direction: a known problem described in prose with nothing tracking it reads, six months later, as a thing somebody decided was fine.
Three small changes:
docs/roadmap.md— the Security section now lists TerminalSegmentReachedInternalNetwork cannot fire — the firewall logs blocks only #223, which is where the index of open work lives.docs/observability.md— the paragraph that records the measurement now names the issue that would arm the alert.security-overview.json— the caveat panel cites TerminalSegmentReachedInternalNetwork cannot fire — the firewall logs blocks only #223 the way it already cites Extend Suricata to Degens (VLAN 10) #89 for the unwatched VLANs and Detect Suricata being dead — a quiet IDS and a stopped one look identical #90 for detecting Suricata dying. One-line diff; no panel, query or layout change.make validatepasses: 7 dashboards, 140 panels, 132 PromQL and 28 LogQL expressions,docs OK.🤖 Generated with Claude Code