Skip to content

Track the dead segmentation alert as #223 - #224

Merged
Gerrrt merged 1 commit into
mainfrom
gerrrt/link-pass-logging-issue
Sep 1, 2026
Merged

Gerrrt merged 1 commit into
mainfrom
gerrrt/link-pass-logging-issue

Conversation

@Gerrrt

@Gerrrt Gerrrt commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Follow-up to #82 and #223.

#223 records that TerminalSegmentReachedInternalNetwork cannot fire — the firewall logs blocks only, and the rule matches action="pass". The finding was already written down in docs/observability.md and stated on the homelab-security dashboard, but neither pointed at an issue, and docs/roadmap.md did not list it at all.

That is this repository's recurring failure seen from the other direction: a known problem described in prose with nothing tracking it reads, six months later, as a thing somebody decided was fine.

Three small changes:

make validate passes: 7 dashboards, 140 panels, 132 PromQL and 28 LogQL expressions, docs OK.

🤖 Generated with Claude Code

#223 records that TerminalSegmentReachedInternalNetwork cannot fire —
the firewall logs blocks only and the rule matches action="pass". The
finding was already written down in observability.md and stated on the
dashboard, but neither pointed at an issue, and roadmap.md did not list
it at all.

That is the gap this repository keeps rediscovering from the other
direction: a known problem described in prose with nothing tracking it
reads, six months later, as a thing somebody decided was fine.

The dashboard's caveat panel now cites #223 the way it already cites #89
for the unwatched VLANs and #90 for detecting Suricata dying.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings September 1, 2026 04:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Changes are limited to documentation/caveat text updates that align with the PR description and do not introduce behavioral risk.

Pull request overview

This PR adds explicit issue tracking for the known “dead” Loki alert TerminalSegmentReachedInternalNetwork by referencing issue #223 in the roadmap, observability documentation, and the security overview dashboard’s caveats.

Changes:

  • Add #223 to the Security section of docs/roadmap.md so it appears in the canonical index of open work.
  • Update docs/observability.md to link the documented finding to #223.
  • Update the security-overview.json caveat text to cite #223 alongside the existing issue references.
File summaries
File Description
stacks/observability/grafana/dashboards/security-overview.json Adds a #223 citation in the dashboard caveat explaining why the pass-based alert cannot fire.
docs/roadmap.md Lists #223 in the Security roadmap section as tracked open work.
docs/observability.md Links the documented “cannot fire” finding to issue #223.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/observability.md Resolved
@Gerrrt
Gerrrt merged commit 1f29b16 into main Sep 1, 2026
4 checks passed
@Gerrrt
Gerrrt deleted the gerrrt/link-pass-logging-issue branch September 1, 2026 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants