Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

ProxyBay related cleanups - #4474

Closed
funkydude wants to merge 2 commits into
EFForg:masterfrom
funkydude:proxybay
Closed

funkydude wants to merge 2 commits into
EFForg:masterfrom
funkydude:proxybay

Conversation

@funkydude

Copy link
Copy Markdown
Contributor

Removes an old, dead ruleset.
Splits one out.
Updates current one with some comments.

More work needed in a separate PR.

Comment thread src/chrome/content/rules/ProxyBay.xml Outdated
@@ -0,0 +1,15 @@
<!--
HSTS: max-age=15552000; includeSubDomains; preload || Not in the list yet

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@funkydude

Copy link
Copy Markdown
Contributor Author

@J0WI Resolved

@J0WI

J0WI commented Mar 25, 2016

Copy link
Copy Markdown
Contributor

preloaded sites don't need to be added to HTTPS Everywhere. You can safely remove the proxybay.la rules.

@funkydude

Copy link
Copy Markdown
Contributor Author

@J0WI there doesn't appear to be a clear consensus on that right now: #4396

On top of that, since this domain will likely change again soon, I do not wish to delete and re-create it for whatever time it takes for the new domain to be added to the list. It will also need forwarding from the old to the new domain. So, I'm leaving it in for this one in specific.

@J0WI

J0WI commented Apr 6, 2016

Copy link
Copy Markdown
Contributor

I think this will be fixed in #4462

@Hainish Hainish added the top-1k label Aug 19, 2016
@jeremyn

jeremyn commented Aug 27, 2016

Copy link
Copy Markdown
Contributor

@funkydude @J0WI I noticed this because it's old and top-1k. What's blocking this?

@J0WI

J0WI commented Aug 28, 2016

Copy link
Copy Markdown
Contributor

@jeremyn the point is, that sites in the HSTS preload list don't need to be in HTTPS Everywhere, because they are already forced by the browser. I think browsers doings this well than HTTPS Everywhere and it would shrink our extension.

Quoting @jsha from the mailing list:

It's fine to remove an auto-generated HSTS rule, if:

  • Its hosts are now fully covered in the HSTS preload list.
  • The secure cookie rules are not necessary (e.g. the site secures all its cookies, or only sets cookies that are scoped exactly to the covered HSTS domain).

But we haven't cleaned up our rules yet (see #4396 (comment)).

@jeremyn

jeremyn commented Aug 28, 2016

Copy link
Copy Markdown
Contributor

@J0WI So does that mean the blocker is you want @funkydude to remove ProxyBay.xml from the pull request?

@J0WI

J0WI commented Aug 28, 2016

Copy link
Copy Markdown
Contributor

Either this or at least adding a comment, that we can easily clean up preloaded hosts if we want to do this.

@J0WI J0WI mentioned this pull request Aug 30, 2016
@J0WI

J0WI commented Aug 30, 2016

Copy link
Copy Markdown
Contributor

I think I'll prefer #5013 which is more up to date and also includes more PirateBay related hosts.

@J0WI

J0WI commented Sep 13, 2016

Copy link
Copy Markdown
Contributor

closed by #5013

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants