Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Add HSTS-based rewrites to the Node rewriter. - #4462

Closed
jsha wants to merge 1 commit into
masterfrom
hsts-transform
Closed

jsha wants to merge 1 commit into
masterfrom
hsts-transform

Conversation

@jsha

@jsha jsha commented Mar 24, 2016

Copy link
Copy Markdown
Member

Also, bring all dependencies up-to-date and remove the hacky workaround for
explosive regex in URIjs (seems to be fixed upstream now).

cc @Hainish @cooperq

Also, bring all dependencies up-to-date and remove the hacky workaround for
explosive regex in URIjs (seems to be fixed upstream now).
}
console.log(' <target host="' + entry.name + '" />');
if (entry.include_subdomains) {
console.log(' <target host="*.' + entry.name + '" />');

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll probably want to make this entry.name.trim() because the upstream transport_security_state_static.json mistakenly contains spaces after some domains.

@fuglede

fuglede commented May 16, 2016

Copy link
Copy Markdown
Contributor

Just a comment: Perhaps(?) it might also be of interest to include those hosts which are pending publication in Chromium; as of right now, there are 3405 such hosts, which is rather significant when compared to the ~11000 in the Chromium preload list.

@Hainish

Hainish commented May 16, 2016

Copy link
Copy Markdown
Member

@fuglede I suggest against this, since there is a quality-control process between the point of submission and inclusion, which verifies that the HSTS header is actually present on the remote HTTPS endpoint, that includeSubdomains=true and perhaps other checks as well. Including the pending domains may present a vector for DoS, since one may submit a domain for which HTTPS is not offered at all.

@fuglede

fuglede commented May 17, 2016

Copy link
Copy Markdown
Contributor

@Hainish: Actually checks are carried out already on submission. To see this, try submitting fleetpal.io to https://hstspreload.appspot.com, and note that it does not appear on https://hstspreload.appspot.com/pending afterwards; in particular, this checks for includeSubdomains (and, as far as I can tell, every single one of the requirements specified on the submission page).

What exactly is done between the removal hosts from the pending lists and the addition to the live lists, I'm not 100% sure about; the docs mention "manual" reviews but not exactly what they entail.

@fuglede

fuglede commented May 19, 2016

Copy link
Copy Markdown
Contributor

The above comment is partly voided by their new change to how the site works. In that, we have in particular the following:

However, I think site owners will appreciate that the requirements are now all checked when the domain is submitted to hstspreload.appspot.com – there is no secondary review with additional checks, and you get feedback immediately when you enter the domain on the submission site.

On the other hand, it looks like this change will bring about updates more often, so that the added value would be less, comparatively.

@lgarron

lgarron commented May 19, 2016 •

Copy link
Copy Markdown

The above comment is partly voided by their new change to how the site works.

Yep, all the requirements are checked at submission time now. However, tons of sites develop problems in the few weeks after submission. I would highly recommend scanning using hstspreloadbatch

On the other hand, it looks like this change will bring about updates more often, so that the added value would be less, comparatively.

Note that this is a separate problem that isn't solved yet. Updates will continue to be throttled to ≈once per Chrome version until someone (probably me) ports https://github.com/chromium/hstspreload/blob/master/cmd/transport_security_state_static_generate/transport_security_state_static_generate.go to Python and adds it to the Chromium build process.

@Hainish

Hainish commented Jul 14, 2016

Copy link
Copy Markdown
Member

@jsha do you have time to look at the few comments I made? @J0WI marked this with the Before Next Release milestone, but I don't think it's vital for the next release.

@jsha jsha removed this from the Before the Next Release milestone Jul 14, 2016
@jsha

jsha commented Jul 14, 2016

Copy link
Copy Markdown
Member Author

Yeah, I removed that milestone - I don't think this is super urgent.

@J0WI

J0WI commented Jul 14, 2016

Copy link
Copy Markdown
Contributor

I added the milestone here to get rid of the "Should we add preloaded HSTS rules or not"-dilemma.

@Hainish Hainish mentioned this pull request Dec 9, 2016
@cowlicks

Copy link
Copy Markdown
Contributor

@jsha closing this since it's stale, feel free to re-open

@cowlicks cowlicks closed this Sep 15, 2017
@Hainish
Hainish deleted the hsts-transform branch October 3, 2017 21:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants