Repository navigation
Conversation
Also, bring all dependencies up-to-date and remove the hacky workaround for explosive regex in URIjs (seems to be fixed upstream now).
| } | ||
| console.log(' <target host="' + entry.name + '" />'); | ||
| if (entry.include_subdomains) { | ||
| console.log(' <target host="*.' + entry.name + '" />'); |
There was a problem hiding this comment.
You'll probably want to make this entry.name.trim() because the upstream transport_security_state_static.json mistakenly contains spaces after some domains.
|
Just a comment: Perhaps(?) it might also be of interest to include those hosts which are pending publication in Chromium; as of right now, there are 3405 such hosts, which is rather significant when compared to the ~11000 in the Chromium preload list. |
|
@fuglede I suggest against this, since there is a quality-control process between the point of submission and inclusion, which verifies that the HSTS header is actually present on the remote HTTPS endpoint, that includeSubdomains=true and perhaps other checks as well. Including the pending domains may present a vector for DoS, since one may submit a domain for which HTTPS is not offered at all. |
|
@Hainish: Actually checks are carried out already on submission. To see this, try submitting fleetpal.io to https://hstspreload.appspot.com, and note that it does not appear on https://hstspreload.appspot.com/pending afterwards; in particular, this checks for includeSubdomains (and, as far as I can tell, every single one of the requirements specified on the submission page). What exactly is done between the removal hosts from the pending lists and the addition to the live lists, I'm not 100% sure about; the docs mention "manual" reviews but not exactly what they entail. |
|
The above comment is partly voided by their new change to how the site works. In that, we have in particular the following:
On the other hand, it looks like this change will bring about updates more often, so that the added value would be less, comparatively. |
Yep, all the requirements are checked at submission time now. However, tons of sites develop problems in the few weeks after submission. I would highly recommend scanning using
Note that this is a separate problem that isn't solved yet. Updates will continue to be throttled to ≈once per Chrome version until someone (probably me) ports https://github.com/chromium/hstspreload/blob/master/cmd/transport_security_state_static_generate/transport_security_state_static_generate.go to Python and adds it to the Chromium build process. |
|
@jsha do you have time to look at the few comments I made? @J0WI marked this with the Before Next Release milestone, but I don't think it's vital for the next release. |
|
Yeah, I removed that milestone - I don't think this is super urgent. |
|
I added the milestone here to get rid of the "Should we add preloaded HSTS rules or not"-dilemma. |
|
@jsha closing this since it's stale, feel free to re-open |
Also, bring all dependencies up-to-date and remove the hacky workaround for
explosive regex in URIjs (seems to be fixed upstream now).
cc @Hainish @cooperq