Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Testing cleanups for PR 2731 - #2779

Merged
semenko merged 13 commits into
EFForg:masterfrom
semenko:testing-cleanups
Sep 6, 2015
Merged

semenko merged 13 commits into
EFForg:masterfrom
semenko:testing-cleanups

Conversation

@semenko

@semenko semenko commented Sep 6, 2015

Copy link
Copy Markdown
Contributor

Tiny nits for PR #2731

Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
No code changes. Only automated indent fix.

Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
@semenko

semenko commented Sep 6, 2015

Copy link
Copy Markdown
Contributor Author

@TheNavigat Mind taking a look?

See: travis-ci/travis-ci#3239

Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
Comment thread test/chromium/script.py

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is unreachable. You probably need to remove sys.exit(1) at line 68.

Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
@semenko

semenko commented Sep 6, 2015

Copy link
Copy Markdown
Contributor Author

Good call! Anything else?

@TheNavigat

Copy link
Copy Markdown
Contributor

Nope, LGTM. Good work!

semenko added a commit that referenced this pull request Sep 6, 2015
@semenko
semenko merged commit 3ca98ef into EFForg:master Sep 6, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants