Repository navigation
Getting Travis CI to work with Chromium testing - #2731
Conversation
|
Okay, the PR's ready @semenko |
|
On a side note, I'm delighted as fuck that we finally got this working. Just thought that this comment deserves to exist here. |
…g it from firefox.sh to test.sh
|
Whoa -- awesome! Looks like Travis isn't quite as happy as it claims. Click the little green arrow by the commit for the full log: and early on
|
|
I mistakenly returned a 0 exit code in test/script.py when ChromeDriver's missing. Regarding Travis, whoa... "Disallowing"?! I checked the ticket again, read it line by line, and now I get why it isn't (and will never) work. It's because of Xvfb, Travis doesn't support it. I used a trick before to run Chrome and Chromedriver headlessly, by using pyvirtualdisplay, but as I checked right now, that relies on Xvfb as well, which is (again) not supported by Travis. So yea... What to do now? |
|
Perhaps something like: travis-ci/travis-ci#938 (comment) ? Not 100% clear that's successful for the commenter. You can either remove Chrome from Travis here (and I'll merge this after a more careful review) and try a separate PR for Chrome + Travis (or Sauce Labs, I guess...), or try the above here. |
|
This looks good, https://github.com/andy11/ScriptObservatory/blob/4587f5400dd95edc4fbac7a7a0a59c81532e3bf9/.travis.yml . I'll try it out in an hour or two. If it failed I'll remove/comment Chrome's testing in test.sh and then we can merge this PR and start another one to slowly get the whole thing fixed step by step. Oh and Xvfb does work. Sorry, that was a mistake. I might try the pyvirtualdisplay trick. It might work, who knows. |
|
How can I test Travis locally? |
3f8d7a5 to
3918baa
Compare
595face to
057114b
Compare
|
https://travis-ci.org/EFForg/https-everywhere/builds/78631398
:( |
|
Heh, this has gone pretty deep down the rabbit hole. I'm guessing this breaks because a deprecated setuid/setgid requirement for Chromium (that we can ultimately fix with --disable-setuid-sandbox). Switch sudo: false to sudo: true, and I'll do some offline tests then hopefully merge :) |
638a258 to
f536d7d
Compare
|
I tried using --disable-setuid-sandbox, https://travis-ci.org/EFForg/https-everywhere/builds/78634510. Didn't work. I'll switch it to required (I think we need required, not true) and push. |
4bfb2df to
066267b
Compare
|
There's something weird happening. The path part is what makes Chrome fail. See here, https://travis-ci.org/EFForg/https-everywhere/builds/78636591 |
a9007db to
27158b9
Compare
|
So, the PATH command won't work, and moving Selenium expects ChromeDriver to be in a PATH location, and does not try to locate chromedriver in its own directory. I can explicitly force it to do, though. I'll try that right now. |
e43f94e to
540c60a
Compare
540c60a to
1991398
Compare
|
The non-sudo script is ready. This deserves a party. |
|
Awesome! Thanks so much for your hard work! I'll do some offline testing, and hopefully merge this tonight! 👍 |
|
Cool -- a couple nits that I'll fix post merge. Thanks again! |
Getting Travis CI to work with Chromium testing
This PR is not complete. test.sh does not start Chromium testing because of a bug I'm still trying to figure out how to fix. However, it's fine for me if someone would like to merge it and let me create another PR to fix this issue. Otherwise, I'm still figuring out how to make Chromium testing run properly through test.sh.