This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
When 'Block all unencrypted requests' is checked, FTP is still allowed. - #15813
Merged
Merged
Conversation
Member
Author
|
@bcyphers care to look this over? |
Contributor
|
Sure! I'll take a look later this week. |
Collaborator
|
Related: #2311 |
Hainish
force-pushed
the
fix-blocking-ftp
branch
from
June 23, 2018 01:06
2d40ddd to
10529f0
Compare
bcyphers
reviewed
Jun 25, 2018
| // Registers the handler for requests | ||
| // See: https://github.com/EFForg/https-everywhere/issues/10039 | ||
| chrome.webRequest.onBeforeRequest.addListener(onBeforeRequest, {urls: ["*://*/*"]}, ["blocking"]); | ||
| chrome.webRequest.onBeforeRequest.addListener(onBeforeRequest, {urls: ["<all_urls>"]}, ["blocking"]); |
Contributor
There was a problem hiding this comment.
Is there a reason to use <all_urls> rather than enumerate ["*://*/*", "ftp://*/*"]?
Member
Author
There was a problem hiding this comment.
Firefox doesn't seem to care either way, and never triggers this hook even with FTP urls. I think you're right though, and enumerating both is a more constrained criteria than just <all_urls>.
This is a fix for Chromium. Firefox still doesn't recognize the <all_urls> special string for FTP urls.
Hainish
force-pushed
the
fix-blocking-ftp
branch
from
June 25, 2018 21:46
10529f0 to
c54ab60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for Chromium. Firefox still doesn't recognize the
<all_urls> special string for FTP urls.