You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
I'm not 100% sure that I've understood the original intention of the 'Block all HTTP requests' feature, but I personally enable it when I want to make sure that I don't accidentally receive anything over an unencrypted connection.
If that is the intended reason, then I would like to suggest that you add the "ftp:" protocol handler to the blacklist as well, since browsers are capable of serving unencrypted content over FTP too.
You've got the right idea about the intent. Probably this should be a whitelist containing just HTTPS rather than a blacklist. Thanks for the bug report!
Great. When you do, keep in mind that "filesystem:" URIs also trigger the onBeforeRequest event (for some reason) in Chrome. For example, this will trigger the onBeforeRequest on a "filesystem:" URI without ever sending a request and thus shouldn't be blocked:
function onInitFs(fs) {
fs.root.getFile('ex.png', {create: true}, function(fileEntry) {
fileEntry.createWriter(function(fileWriter) {
// Create a new Blob and write it to ex.png.
var blob = new Blob([':)'], {type: 'image/png'});
fileWriter.write(blob);
elem=document.createElement("img");
//Create a filesystem: URL and append it to the current document
elem.src=fileEntry.toURL();
document.documentElement.appendChild(elem);
});
});
}
window.requestFileSystem = window.requestFileSystem || window.webkitRequestFileSystem;
window.requestFileSystem(window.TEMPORARY, 1024*1024 /*1MB*/, onInitFs);
Activity
jsha commentedon Jul 23, 2015
You've got the right idea about the intent. Probably this should be a whitelist containing just HTTPS rather than a blacklist. Thanks for the bug report!
avlidienbrunn commentedon Jul 24, 2015
Great. When you do, keep in mind that "filesystem:" URIs also trigger the onBeforeRequest event (for some reason) in Chrome. For example, this will trigger the onBeforeRequest on a "filesystem:" URI without ever sending a request and thus shouldn't be blocked:
gripedthumbtacks commentedon Jan 19, 2017
This is still present and "Block all unencrypted requests" does NOT prevent unencrypted FTP (!)
A proper fix would, at minimum, block the ftp:// protocol scheme when "Block all unencrypted requests" is enabled.
Hainish commentedon Jun 25, 2018
Fixed by #15813 (though Firefox is still broken, I've filed a bug report: https://bugzilla.mozilla.org/show_bug.cgi?id=1471065)