Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/chrome/content/rules/Flickr.xml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@
<!--securecookie host="^\.flickr\.com$" name="^(BX|admsort|cookie_session|current_identity|density|ffs|fldetectedlang|flrb|flrbcr|flrbgdrp|flrbgmrp|flrbgrp|flrbp|flrbs|fltoto|just_registered|localization|memsort|modsort|photoPHS|photoPWS|vp|xb)$" /-->
<!--securecookie host="^www\.flickr\.com$" name="^(liqph|liqpw|ywandp)" /-->

<securecookie host=".*\.flickr\.com$" name="^(?!current_identity$).+" />
<!-- If we secure this cookie, login fails. -->
<!-- <securecookie host=".*\.flickr\.com$" name="^(?!current_identity$).+" /> -->

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we delete this and the few lines above it instead of commenting it out?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one in particular I chose to comment rather than deleting, because it's been fixed in the past and has reappeared. So it's useful to have a comment saying "don't do this."

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough



<rule from="^http:"
Expand Down
6 changes: 3 additions & 3 deletions src/install.rdf
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<Description>
<em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id>
<em:minVersion>26.0</em:minVersion>
<em:maxVersion>99.*</em:maxVersion>
<em:maxVersion>40.0</em:maxVersion>
</Description>
</em:targetApplication>
<!-- Seamonkey -->
Expand All @@ -46,15 +46,15 @@
<Description>
<em:id>{a79fe89b-6662-4ff4-8e88-09950ad4dfde}</em:id>
<em:minVersion>0.1</em:minVersion>
<em:maxVersion>99.*</em:maxVersion>
<em:maxVersion>40.0</em:maxVersion>
</Description>
</em:targetApplication>
<!-- Firefox Mobile for Android -->
<em:targetApplication>
<Description>
<em:id>{aa3c5121-dab2-40e2-81ca-7ea25febc110}</em:id>
<em:minVersion>26.0</em:minVersion>
<em:maxVersion>99.*</em:maxVersion>
<em:maxVersion>40.0</em:maxVersion>
</Description>
</em:targetApplication>
</Description>
Expand Down