Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Fix Flickr login. - #1577

Merged
cooperq merged 1 commit into
EFForg:masterfrom
jsha:fix-flickr
Apr 24, 2015
Merged

cooperq merged 1 commit into
EFForg:masterfrom
jsha:fix-flickr

Conversation

@jsha

@jsha jsha commented Apr 24, 2015

Copy link
Copy Markdown
Member

cc @pde @cooperq for review

Also fix max versions in install.rdf.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we delete this and the few lines above it instead of commenting it out?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one in particular I chose to comment rather than deleting, because it's been fixed in the past and has reappeared. So it's useful to have a comment saying "don't do this."

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough

cooperq added a commit that referenced this pull request Apr 24, 2015
@cooperq
cooperq merged commit 9687fbe into EFForg:master Apr 24, 2015
@jsha

jsha commented Apr 27, 2015

Copy link
Copy Markdown
Member Author

@2d1: Apologies, I was stressed and in a rush and messed this up. I tested Flickr on Friday in response to https://twitter.com/AlanDejecacion/status/591631531392663553, and found that login did in fact break with the same cookie error you fixed in November. I also found that removing the securecookie rule fixed it.

However, as of this morning I can no longer reproduce, so this may be intermittent.

Also, apologies for maligning your code: I actually did remember that you had fixed this in November by removing a cookie, and had assumed that because the site was breaking in the exact same way, someone else had undone your fix. This seemed like such a straightforward diff that I didn't think to check the git log.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants