Repository navigation
Fix Flickr login. - #1577
Fix Flickr login.#1577
Conversation
Also fix max versions in install.rdf.
There was a problem hiding this comment.
Should we delete this and the few lines above it instead of commenting it out?
There was a problem hiding this comment.
This one in particular I chose to comment rather than deleting, because it's been fixed in the past and has reappeared. So it's useful to have a comment saying "don't do this."
|
@2d1: Apologies, I was stressed and in a rush and messed this up. I tested Flickr on Friday in response to https://twitter.com/AlanDejecacion/status/591631531392663553, and found that login did in fact break with the same cookie error you fixed in November. I also found that removing the securecookie rule fixed it. However, as of this morning I can no longer reproduce, so this may be intermittent. Also, apologies for maligning your code: I actually did remember that you had fixed this in November by removing a cookie, and had assumed that because the site was breaking in the exact same way, someone else had undone your fix. This seemed like such a straightforward diff that I didn't think to check the git log. |
cc @pde @cooperq for review