Repository navigation
wait for option page to load - #15624
Conversation
|
|
||
| self.driver.refresh() | ||
|
|
||
| self.load_options() |
There was a problem hiding this comment.
I think we want to keep this, since we want to assure that the option is selected after the options page is reloaded, not just that it's checked on the same page after we check it.
There was a problem hiding this comment.
We'll need to add an additional sleep after this too, I suspect.
There was a problem hiding this comment.
I'm not sure if it's necessary since the tests are running one by one. Otherwise do we need another load_option after the second reload?
|
@Giltyhub it's not, this is for a different test. |
|
@gloomy-ghost can you explain why these failures are being triggered in the first place, and how this fixes it? I'm a bit confused what the sleep is fixing here. |
|
I used a VM to do a throttle test and the second Here is how the values get loaded: https-everywhere/chromium/pages/options/ux.js Lines 45 to 49 in 2166ca3 |
2e98b60 to
f3fd496
Compare
|
Thank you! |
it should migrate these failing:
https://travis-ci.org/EFForg/https-everywhere/jobs/388095434
https://travis-ci.org/EFForg/https-everywhere/jobs/388093906
https://travis-ci.org/EFForg/https-everywhere/jobs/388101456