You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
It still seems to occur. I still have branches that fail in either or both of the chrome and firefox tests after rebasing to the lastest eff master branch today.
I wasn't able to consistently get failures for test/selenium/test_navigation.py::TestNavigation::test_redirect yesterday. I kind of assume the failure is due to the test URL loading before the extension has the chance to load. If we add an additional time.sleep statement before the URL load, this should do the trick. I'll test some more today.
It's similar but would have to apply to test/selenium/test_navigation.py instead. It strikes me as a band-aid approach - ideally the extension should actually load before any URLs in the browser load, but I'm not sure if that's possible to ensure.
@Hainish A similar error still occurs with test_show_counter in test_options.py.
I don't have the means to test this right now, but adding a sleep() in a similar fashion should resolve this remaining issue.
=================================== FAILURES ===================================
________________________ OptionsTest.test_show_counter _________________________
self = <test_options.OptionsTest testMethod=test_show_counter>
def test_show_counter(self):
selector = '#showCounter'
self.load_options()
el = self.query_selector(selector)
> self.assertTrue(el.is_selected())
E AssertionError: False is not true
test/selenium/test_options.py:15: AssertionError
=============== 1 failed, 7 passed, 1 skipped in 118.21 seconds ================
Activity
Giltyhub commentedon Apr 27, 2018
see as well https://api.travis-ci.org/v3/job/371925476/log.txt
numismatika commentedon May 5, 2018
Could that be a side-effect of #15157 ?
Giltyhub commentedon May 5, 2018
@numismatika no i was getting it before it was merged
Giltyhub commentedon May 14, 2018
see for possible solution #15396
J0WI commentedon May 15, 2018
Adding "high prio" due #15396 (comment)
numismatika commentedon May 20, 2018
It still seems to occur. I still have branches that fail in either or both of the chrome and firefox tests after rebasing to the lastest eff master branch today.
Giltyhub commentedon May 27, 2018
@numismatika metoo
J0WI commentedon May 28, 2018
@Hainish @bcyphers are you already aware of this issue here?
Hainish commentedon Jun 7, 2018
Thanks @J0WI - I'll take a look tomorrow.
Hainish commentedon Jun 8, 2018
I wasn't able to consistently get failures for
test/selenium/test_navigation.py::TestNavigation::test_redirectyesterday. I kind of assume the failure is due to the test URL loading before the extension has the chance to load. If we add an additionaltime.sleepstatement before the URL load, this should do the trick. I'll test some more today.J0WI commentedon Jun 8, 2018
Is this something covered by #15624?
Hainish commentedon Jun 8, 2018
It's similar but would have to apply to
test/selenium/test_navigation.pyinstead. It strikes me as a band-aid approach - ideally the extension should actually load before any URLs in the browser load, but I'm not sure if that's possible to ensure.Hainish commentedon Jun 8, 2018
I was able to consistently reproduce this error - adding the
sleepin 06870de fixes it.injust commentedon Jun 9, 2018
@Hainish A similar error still occurs with
test_show_counterin test_options.py.I don't have the means to test this right now, but adding a
sleep()in a similar fashion should resolve this remaining issue.