Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Travis CI Chrome/Firefox build error #15239

Closed

Description

@Giltyhub

I've been getting it a lot of times see for example https://travis-ci.org/EFForg/https-everywhere/jobs/370686501

test/selenium/test_navigation.py::TestNavigation::test_http_site_not_blocked PASSED
test/selenium/test_navigation.py::TestNavigation::test_httpnowhere_blocks PASSED
test/selenium/test_navigation.py::TestNavigation::test_no_redirect_when_disabled PASSED
test/selenium/test_navigation.py::TestNavigation::test_redirect FAILED
test/selenium/test_options.py::OptionsTest::test_options PASSED
test/selenium/test_options.py::OptionsTest::test_show_counter PASSED
test/selenium/test_popup.py::TestPopup::test_disable_enable PASSED
test/selenium/test_popup.py::TestPopup::test_http_nowhere PASSED
test/selenium/test_popup.py::TestPopup::test_rule_shown PASSED
=================================== FAILURES ===================================
_________________________ TestNavigation.test_redirect _________________________
self = <test_navigation.TestNavigation testMethod=test_redirect>
    def test_redirect(self):
        self.driver.get(kittens_url)
>       self.assertTrue(self.driver.current_url.startswith('https'))
E       AssertionError: False is not true
test/selenium/test_navigation.py:13: AssertionError
===================== 1 failed, 8 passed in 48.46 seconds ======================

Activity

  1. Giltyhub commented on Apr 27, 2018

    @Giltyhub
    ContributorAuthor
  2. numismatika commented on May 5, 2018

    @numismatika
    Contributor

    Could that be a side-effect of #15157 ?

  3. Giltyhub commented on May 5, 2018

    @Giltyhub
    ContributorAuthor

    @numismatika no i was getting it before it was merged

  4. Giltyhub commented on May 14, 2018

    @Giltyhub
    ContributorAuthor

    see for possible solution #15396

  5. J0WI commented on May 15, 2018

    @J0WI
    Contributor

    Adding "high prio" due #15396 (comment)

  6. numismatika commented on May 20, 2018

    @numismatika
    Contributor

    It still seems to occur. I still have branches that fail in either or both of the chrome and firefox tests after rebasing to the lastest eff master branch today.

  7. Giltyhub commented on May 27, 2018

    @Giltyhub
    ContributorAuthor
  8. J0WI commented on May 28, 2018

    @J0WI
    Contributor

    @Hainish @bcyphers are you already aware of this issue here?

  9. Hainish commented on Jun 7, 2018

    @Hainish
    Member

    Thanks @J0WI - I'll take a look tomorrow.

  10. Hainish commented on Jun 8, 2018

    @Hainish
    Member

    I wasn't able to consistently get failures for test/selenium/test_navigation.py::TestNavigation::test_redirect yesterday. I kind of assume the failure is due to the test URL loading before the extension has the chance to load. If we add an additional time.sleep statement before the URL load, this should do the trick. I'll test some more today.

  11. J0WI commented on Jun 8, 2018

    @J0WI
    Contributor

    Is this something covered by #15624?

  12. Hainish commented on Jun 8, 2018

    @Hainish
    Member

    It's similar but would have to apply to test/selenium/test_navigation.py instead. It strikes me as a band-aid approach - ideally the extension should actually load before any URLs in the browser load, but I'm not sure if that's possible to ensure.

  13. Hainish commented on Jun 8, 2018

    @Hainish
    Member

    I was able to consistently reproduce this error - adding the sleep in 06870de fixes it.

  14. injust commented on Jun 9, 2018

    @injust
    Contributor

    @Hainish A similar error still occurs with test_show_counter in test_options.py.
    I don't have the means to test this right now, but adding a sleep() in a similar fashion should resolve this remaining issue.

    =================================== FAILURES ===================================
    ________________________ OptionsTest.test_show_counter _________________________
    self = <test_options.OptionsTest testMethod=test_show_counter>
        def test_show_counter(self):
            selector = '#showCounter'
            self.load_options()
            el = self.query_selector(selector)
    >       self.assertTrue(el.is_selected())
    E       AssertionError: False is not true
    test/selenium/test_options.py:15: AssertionError
    =============== 1 failed, 7 passed, 1 skipped in 118.21 seconds ================
    
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions