Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Bot housekeeping - #13459

Merged
Hainish merged 2 commits into
EFForg:masterfrom
strugee:squash-probot-deprecations
Nov 2, 2017
Merged

Hainish merged 2 commits into
EFForg:masterfrom
strugee:squash-probot-deprecations

Conversation

@strugee

@strugee strugee commented Nov 2, 2017

Copy link
Copy Markdown
Contributor
  • Bump deps
  • Squash a deprecation

Note that I upgraded to probot@3 and only had time to do minimal testing. But I'm not too worried.

@strugee

strugee commented Nov 2, 2017 •

Copy link
Copy Markdown
Contributor Author

/cc @Hainish @koops76

@Hainish
Hainish merged commit 99b126b into EFForg:master Nov 2, 2017
@ghost

ghost commented Nov 2, 2017

Copy link
Copy Markdown

@strugee Why pinging me?

@strugee

strugee commented Nov 2, 2017

Copy link
Copy Markdown
Contributor Author

@koops76 ¯_(ツ)_/¯ you've reviewed my PRs in the past so I figured you might want to do so again. No particular reason though.

@strugee
strugee deleted the squash-probot-deprecations branch November 2, 2017 18:39
@ghost

ghost commented Nov 2, 2017

Copy link
Copy Markdown

@strugee I think the bot should be moved into a separate repository since it doesn't depend on HTTPSE and vice-versa.

@strugee

strugee commented Nov 2, 2017 •

Copy link
Copy Markdown
Contributor Author

@koops76 I would be fine with that; it'd make issue tracking easier as well. @Hainish requested it to go into util/: #6322 (comment)

If it is split into a separate repository it'd be nice to recreate the commit history in #11615 which was lost when the branch got squashed and merged.

@Hainish

Hainish commented Nov 2, 2017

Copy link
Copy Markdown
Member

I think it's convenient to have all HTTPS Everywhere-related utilities in the same repo, for easy reference.

@ghost

ghost commented Nov 2, 2017

Copy link
Copy Markdown

@Hainish These tools have different licenses, different authors and possibly should have different maintainers. I think it's better to move it to a separate repo and give @strugee push access to it.

@Hainish

Hainish commented Nov 2, 2017

Copy link
Copy Markdown
Member

@koops76

Luckily we state the different license in LICENSE.txt, see the relevant discussion here: #13062 (comment)

We may want to have someone else maintain this tool if @strugee becomes unavailable. Other tools are under utils/ for similar reasons.

@ghost

ghost commented Nov 2, 2017

Copy link
Copy Markdown

@Hainish Can't you add yourself and @cowlicks to collaborators too?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants