Repository navigation
Conversation
|
@Hainish This needs legal review. |
|
We should use GPL v3+, not GPL v2+, right? In any case GPL v2+ "reduces" to GPL v3+ because anyone can immediately re-release GPL v2+ stuff as v3+. |
|
|
@koops76 Oh, hm, I guess Also, contrary to my earlier argument, there is an advantage for GPL v2+ instead of v3+: v2 and v3 are incompatible, so v3+ can't be released with v2-only code. See https://www.gnu.org/licenses/gpl-faq.html#AllCompatibility. However we should probably use GPL v3+ anyway unless the EFF has some specific reason not to. |
|
The language in the current |
|
@Hainish What's going on with that? |
|
There's also a typo at the top of the current, very short
This will sound snarky, but how much time did the legal team spend reviewing this if they missed such a simple thing? |
|
You're right, it does sound snarky 😆 They reviewed new content, in person, with me. That doesn't mean they're making edits in the files themselves. That line was committed on 2010-06-22, so just as the project started. |
|
Despite the FSF recommendations I don't think it's necessary to include the full text of the GPL in every repo that is under that license. It just adds clutter. |
|
There's no ambiguity about "which GPLv2" we're talking about, it's already clear, adding the full body of the document is unnecessary. |
|
@Hainish The stated purpose of this PR and of my earlier issue #7978 is to allow GitHub to automatically detect the license. GitHub still can't do that so the issue is still not solved. Are you saying that the current |
|
Modifying the contents of |
|
GitHub only fails detection if you're doing something really unusual, like we're currently doing with the non-standard Could you please answer my earlier questions:
|
|
Someone contributing to the project seeing a reductive license in the GitHub display may mistakenly assume licensing restrictions that aren't true if we shape the |
|
I'm still confused here. You haven't directly answered my earlier questions, and now you seem to be saying that you're happy we're breaking the GitHub license detection functionality because GitHub's "reductive" display might cause some problem. Could you walk me through an example licensing problem your hypothetical contributor might have? Again, GitHub doesn't have any weird criteria for its detection functionality. If you put the standard license text in any one of a number of standard places, GitHub will find it. There's very little "shaping" required. |
|
Sure. So someone, seeing that the repo is GPLv2+, goes in and modifies code in https://github.com/EFForg/https-everywhere/blob/457dc980f2f36e6fc6a4675fbd78f23413cb9595/utils/create_xpi.py assuming this will be under the GPL as well. In fact, it will not be. This will be under the Python Software Foundation License Version 2. Another example: someone does a mass search-and-replace on files in Stating that we're a GPLv2 project a dicto simpliciter amounts to misleading our contributors as to the licensing specifics of various aspects of our project. So my question to you is this: why would you want to leave these details out? If the answer is just for the sake of a GitHub badge, which is itself contributing to the misleading dynamic, then that's not an acceptable qualification. |
|
@Hainish You're describing a bunch of problems here. Most basically, one integral software application or library has one license. Saying that different integral parts of an application have different licenses makes no sense. It's like if I gave you a tic-tac-toe program and told you that the game is GPLv2 but the part that draws the "X"s is MIT. It's not a matter of argument, it's a matter of dictionary definition of words. Normally what you want to do when using third-party code is to, if possible, relicense that code under your license so you can release everything together under your chosen license. If you can't relicense the third-party code but you still want to use it, then generally you need to enforce some strong separation between your code and the third-party code, and even then you have to consider the third-party code's license. So let's look at the Python stuff. Recent Python 2 software licenses are compatible with GPLv2, so the simple thing to do is to relicense the Python stuff under GPLv2 and call the whole thing a derived work. (Note the Python license might have other requirements to satisfy, for example the 2.7.14 license at my link has the clause:
I don't know what version of the Python license applies to the code HTTPS Everywhere uses, so I don't know if it has a similar clause.) The other option is to claim that HTTPS Everywhere is a combined work and argue that the Python stuff and the other stuff is sufficiently separate. That would be a tough argument given how integrated and customized the build process is with the rest of the main code. There have been a lot of local modifications to Those are the only options: it's a derived work (which seems clear to me) and all under GPLv2, or it's a combined work with strong separations (a tough sell) and therefore can be separately licensed. Having one derived work with different parts licensed separately isn't, logically or semantically, an option. (And, side note, you may want to investigate whether you're violating the Python license by not including the "brief summary of the changes" that that license requires, if that clause in the relevant Python license, unless this summary exists somewhere and I just haven't seen it.) The issue bot code has two different, separate problems. One is that it isn't actually integrated with the main code and there's no reason it should be in the same repository except for programmer convenience. The other is that it uses the Affero GPLv3 license which is not compatible with GPLv2. In the end what I'm saying is that the licensing isn't clear, in fact I would say it's incoherent. Your last comment seems to argue that it's some kind of "GPLv2-but-here-are-some-necessary-details" license, which, maybe (?), but, at least, that's not the same as GPLv2. I'm not sure what to propose as a single to-do item here. Best case, the EFF would go through all the code and split everything up into separate repositories and relicense the necessary third-party code so that each of these repositories can be put under an appropriate license in the usual simple way. I'm not sure what else to suggest beyond that. |
|
Hey @jeremyn -- I appreciate your diligence in wanting to make sure the project's 100% in compliance with relevant licenses. (I'm not a lawyer, and I'm writing this assuming you are not a lawyer; if you are a lawyer then please let me know so I can set my expectations better!) I'd like to make sure I understand the situation. You've suggested that staying with a single Git repository and a single My personal take is that the basic "this repo/application also includes some other work under other licenses" approach is something I'm used to seeing, e.g., in Zulip, a MediaWiki installation, and GitLab. But I could be wrong on the details regarding what makes combined/derived works ok. In order to make sure #13600 (the external dependencies policy) is on a good foundation, we'll need to have a clear architectural decision on whether we're going multirepo or staying with a monorepo. @Hainish is in favor of staying with a monorepo for multiple reasons -- it's easier to manage a single repository in various ways, for instance. I don't really have an opinion yet. I think it'd be useful to have that particular architectural discussion in a separate issue or on the mailing list, outside of the discussion of this particular PR, if you're amenable to that -- let me know. Regardless, as I see it, the most important question in the discussion above is: is the status quo ok, legally speaking? At least, that's how I'm reading your most recent comment above. After all, if we're not legally in the clear, then we have to make a change to come into compliance. So, if you're ok with @Hainish's and my assessment, and the existing legal review and sign-off @Hainish mentioned above, then I figure we're good. If you'd like for one of the EFF staff attorneys to take a fresh look and review the current licensing situation and check whether it needs clarifying, with especial attention to the issues you have brought up, I can ask for that. :) Please let me know. Thanks. |
|
@brainwane Thanks for your detailed response. I'm not a lawyer. If I am directly in error on some point, please correct me. As I said, there are several problems here. The most serious problem is the apparent confusion about the difference between code licensed to the project and the project's license to others, for example with (Think of a simpler example. You write a function The current "multirepo" situation is confusing. The utilities are not well separated, for example I've read that there are some organizations that are so uncomfortable with the AGPL that they won't even allow programmers to have AGPL code on their systems. So including the issue bot with the rest of the code would be a blocker for them. (From a technical standpoint, git submodules are a good way to make "monorepos" look like a "multirepo", if needed. I do that in https://github.com/jeremyn/https-everywhere-dev-environment/tree/master/roles, for example. And some things like the issue bot simply don't need to be attached at all.) For the external dependencies issue #13600, note that the current dependency CodeMirror is licensed under MIT. The MIT license specifically requires including the license text in full, so the current "shorthand" approach in our For the PSF license, in
It seems however that PSF licenses are by minor version, for example the 2.7.14 license is at https://docs.python.org/2/license.html#psf-license-agreement-for-python-release. This matters because of this clause
We can't describe the changes if we don't know what version we started from. Also I don't think this summary of changes is included anywhere in the project. You, @brainwane, wrote:
This isn't how we should look at it. The question "is the status quo ok, legally speaking?" is more about, is the EFF likely to be sued as things are now? I mean legally, other than the PSF and CodeMirror issues mentioned above, the EFF is probably in the clear, and even then, I guess the odds that the PSF would sue the EFF for failing to honor some minor licensing requirement are really low. But, part of being a good open source citizen is making your licensing friendly to potential downstream redistributors. (For example, would Google feel comfortable including HTTPS Everywhere in Chrome?) The project represents many thousands of volunteer hours, contributed under open source terms, and I think it's a matter of respect to the volunteers to go above the bare legal minimum. |
|
What's the current status of this issue at the EFF? Unfortunately, I can't reopen this PR because the original contributor has deleted their GitHub account, but the problem is still active. |
No description provided.