Repository navigation
Fix wildcard-in-the-middle in General-Electric.xml - #12317
Conversation
| <ruleset name="General Electric (partial)"> | ||
|
|
||
| <target host="files.*.geblogs.com"/> | ||
| <target host="*.geblogs.com"/> |
There was a problem hiding this comment.
Could you please also add some (we require at least 3) test urls and a hint, that the blogs itself do not support HTTPS?
There was a problem hiding this comment.
Doesn't rule itself give such a hint? Its regexp clearly covers only files.*.geblogs.com.
There was a problem hiding this comment.
This is the last PR needed before we can forbid wildcards in the middle. @RReverser, are you interested in addressing @J0WI's comments (ie add test urls and a comment why other subdomains do not support HTTPS)?
If you don't have time / don't want to work on this, I can take over.
|
@J0WI, I would really like to move forward and finally block wildcards in the middle in our tests. Do you think it's okay if I edit this branch? Otherwise, I can also open a brand new PR for this. |
|
@Bisaloo since @RReverser is not responding I would say it's okay to take it. |
|
Yeah I indeed don't have much time to contribute to HTTPS Everywhere database anymore - sorry for that, and thanks for taking over. |
| *.files.geblogs.com | ||
| files.*.geblogs.com | ||
|
|
||
| Other subdomains are mismatched or refused. |
There was a problem hiding this comment.
@Bisaloo could you add some more documentation about the behavior of this host?
E.g. why a wildcard is required, but only specific patterns are rewritten.
There was a problem hiding this comment.
How would you describe this? I don't know how to explain it better than what I did.
| <!-- | ||
| Invalid certificate: | ||
| *.files.geblogs.com | ||
| files.*.geblogs.com |
There was a problem hiding this comment.
*.geblogs.com are also mismatching, but see comment below.
|
@Bisaloo would you like to finish this? |
|
@J0WI, as I said, do you have a suggestion of what you would like to see? |
|
There are two wildcards in the I would add a short description, that the service provides 2nd level subdomains for its customers and an additional Maybe it also helps to add their "main" site? |
|
@Bisaloo this seems to be the last bit in #4369 (comment). Would you like to finish this? |
|
🎉 |
See #4369