Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Fix wildcard-in-the-middle in General-Electric.xml - #12317

Merged
pipboy96 merged 11 commits into
EFForg:masterfrom
RReverser:patch-13
Mar 27, 2019
Merged

pipboy96 merged 11 commits into
EFForg:masterfrom
RReverser:patch-13

Conversation

@RReverser

Copy link
Copy Markdown
Contributor

See #4369

<ruleset name="General Electric (partial)">

<target host="files.*.geblogs.com"/>
<target host="*.geblogs.com"/>

@J0WI J0WI Sep 5, 2017 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also add some (we require at least 3) test urls and a hint, that the blogs itself do not support HTTPS?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't rule itself give such a hint? Its regexp clearly covers only files.*.geblogs.com.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the last PR needed before we can forbid wildcards in the middle. @RReverser, are you interested in addressing @J0WI's comments (ie add test urls and a comment why other subdomains do not support HTTPS)?

If you don't have time / don't want to work on this, I can take over.

@Bisaloo

Bisaloo commented Apr 6, 2018

Copy link
Copy Markdown
Collaborator

@J0WI, I would really like to move forward and finally block wildcards in the middle in our tests. Do you think it's okay if I edit this branch? Otherwise, I can also open a brand new PR for this.

@J0WI

J0WI commented Apr 7, 2018

Copy link
Copy Markdown
Contributor

@Bisaloo since @RReverser is not responding I would say it's okay to take it.

@RReverser

Copy link
Copy Markdown
Contributor Author

Yeah I indeed don't have much time to contribute to HTTPS Everywhere database anymore - sorry for that, and thanks for taking over.

*.files.geblogs.com
files.*.geblogs.com

Other subdomains are mismatched or refused.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bisaloo could you add some more documentation about the behavior of this host?
E.g. why a wildcard is required, but only specific patterns are rewritten.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you describe this? I don't know how to explain it better than what I did.

<!--
Invalid certificate:
*.files.geblogs.com
files.*.geblogs.com

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*.geblogs.com are also mismatching, but see comment below.

@J0WI

J0WI commented Jun 2, 2018

Copy link
Copy Markdown
Contributor

@Bisaloo would you like to finish this?

@Bisaloo

Bisaloo commented Jun 2, 2018

Copy link
Copy Markdown
Collaborator

@J0WI, as I said, do you have a suggestion of what you would like to see?

@J0WI

J0WI commented Jun 2, 2018 •

Copy link
Copy Markdown
Contributor

There are two wildcards in the Invalid certificate which says more or less the same as Other subdomains are mismatched or refused.. But there is also wildcard target, which makes it even more unclear. geblogs.com itself is not documented at all.

I would add a short description, that the service provides 2nd level subdomains for its customers and an additional files 3rd level subdomain for static content. For their own static content they use a subdomain with files in the 2nd and the category in the 3rd level.

Maybe it also helps to add their "main" site?

ge.com
www.ge.com
benefits.ge.com
www.benefits.ge.com
ssologin.corporate.ge.com
ssousflogin.corporate.ge.com
digitalsupport.ge.com
go.digital.ge.com
eddie.ge.com
integrity.ge.com
libraries.ge.com
myapps.ge.com
mypassword.ge.com
mytech.ge.com
onehr.ge.com
www.onehr.ge.com
geaeck.registrar.ge.com
ssocentralck.registrar.ge.com
sc.ge.com
supportcentral.ge.com
travel.ge.com

@J0WI

J0WI commented Mar 15, 2019

Copy link
Copy Markdown
Contributor

@Bisaloo this seems to be the last bit in #4369 (comment). Would you like to finish this?

@pipboy96
pipboy96 merged commit 16e6c2b into EFForg:master Mar 27, 2019
@pipboy96

Copy link
Copy Markdown
Contributor

🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants