Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Forbid * in the middle of the target host #4369

Closed

Description

@RReverser

As @jsha pointed in #2981 (comment):

Agreed we want to remove internal * in target hosts, and remove it from support in the rewriter.

So decided to create an issue for 1) removal of support for this in rewriter code 2) having tests that check against such <target host /> occurences.

Activity

  1. RReverser commented on Sep 1, 2017

    @RReverser
    ContributorAuthor

    Looks like after #2981 was fixed by #3603, some new cases appeared:

    src/chrome/content/rules/Argonne-National-Laboratory.xml:	<target host="www.*.anl.gov" />
    src/chrome/content/rules/General-Electric.xml:	<target host="files.*.geblogs.com"/>
    src/chrome/content/rules/GPLHost.xml:	<target host="dtc.*.gplhost.com"/>
    src/chrome/content/rules/Monster.xml:	<target host="hiring.*.monster.com" />
    src/chrome/content/rules/OnSugar.xml:	<target host="secure.*.onsugar.com" />
    src/chrome/content/rules/OnSugar.xml:	<target host="www.*.onsugar.com" />
    src/chrome/content/rules/Projectplace.com.xml:	<target host="projectplace.*.dimelo.com" />
    src/chrome/content/rules/Truenudists.com.xml:	<target host="cdn.*.truenudists.com" />
    src/chrome/content/rules/United-States-Department-of-Energy.xml:	<target host="www.*.doe.gov" />
    src/chrome/content/rules/University-of-Alaska.xml:	<target host="www.*.alaska.edu" />
    src/chrome/content/rules/University-of-Bern.xml:	<target host="www.*.unibe.ch" />
    src/chrome/content/rules/University-of-Idaho.xml:	<target host="www.*.uidaho.edu" />
    src/chrome/content/rules/University-of-Southampton.xml:	<target host="www.*.soton.ac.uk" />
    src/chrome/content/rules/University_of_Houston.xml:	<target host="www.*.uh.edu" />
    src/chrome/content/rules/University_of_Maine.xml:	<target host="www.*.umaine.edu" />
    src/chrome/content/rules/US-Dept-of-Veterans-Affairs.xml:	<target host="www.*.vaforvets.va.gov" />
    src/chrome/content/rules/US-Dept-of-Veterans-Affairs.xml:	<target host="www.*.vba.va.gov" />
    src/chrome/content/rules/US-military.xml:	<target host="usarmy.*.llnwd.net" />
    src/chrome/content/rules/Wikidot.xml:	<target host="1.*.wdfiles.com"/>
    src/chrome/content/rules/Wikidot.xml:	<target host="2.*.wdfiles.com"/>
    src/chrome/content/rules/Wikidot.xml:	<target host="3.*.wdfiles.com"/>
    src/chrome/content/rules/Wikidot.xml:	<target host="4.*.wdfiles.com"/>
    src/chrome/content/rules/Wikidot.xml:	<target host="5.*.wdfiles.com"/>
    src/chrome/content/rules/Wikidot.xml:	<target host="6.*.wdfiles.com"/>
    src/chrome/content/rules/Wikidot.xml:	<target host="7.*.wdfiles.com"/>
    src/chrome/content/rules/Wikidot.xml:	<target host="8.*.wdfiles.com"/>
    src/chrome/content/rules/Wikidot.xml:	<target host="9.*.wdfiles.com"/>
    

    cc @fuglede @jsha @Hainish @Bisaloo - can we attempt to fix these and, this time, add a linter rule to prevent adding similar rules in future?

  2. Bisaloo commented on Sep 2, 2017

    @Bisaloo
    Collaborator
  3. jeremyn commented on Dec 18, 2017

    @jeremyn
    Contributor

    @Bisaloo I've replaced PR #12314 with my new PR #14011. Please update #4369 (comment) above.

  4. pipboy96 commented on Mar 31, 2019

    @pipboy96
    Contributor

    🎉

  5. zoracon commented on Apr 1, 2019

    @zoracon
    Contributor

    Tying in related PR #12319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions