Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Shell scripts, hashbangs and docs require python3.6 #18951

Closed

Description

@jayvdb

Type: code issue

Shell scripts like the test coverage scripts explicitly refer to python3.6, which is increasingly not present on Linux distros which often provide python3.7 or python3.8 now. Also iirc, Python installers for Windows do not provide Python3.6.exe/cmd , and may not even provide a Python3.exe - should re-check that, as Windows users should be able to help with issues like #18745 , and docs saying python3.6 is going to confuse them.

git grep python3.6 has 48 results; very varied.

Suggest using just python3 now, and check the minimum supported version inside the scripts, especially any which dont work on python3.4+ which is a really safe minimum, and provide a useful error message if an insufficient version is installed.

Activity

  1. cschanaj commented on Feb 20, 2020

    @cschanaj
    Collaborator

    As per https://trac.torproject.org/projects/tor/ticket/29097

    ... which ensures that Firefox builds are deterministic, is derived from the Python 3.6 standard library. We've targeted 3.6 for this reason, as well as to enforce similar tooling across different contributor development environments.

    In #6749 (comment), @Hainish explained the rationale behind hard-coding Python 3.6 dependency approximately 2 years ago, which seems unfit for this moment when Python 2.7 is obsolete and Ubuntu 18.04 LTS is released.

    We use the bionic release for Travis CI and docker image. I think it is fine to use #!/bin/usr/env python3 as the Ubuntu LTS ships with Python 3.6 by default if the builds remains deterministic. If possible, we proceed with #9993 in the long term.

  2. zoracon commented on Apr 30, 2020

    @zoracon
    Contributor

    I have been slowly moving into using Python3 instead. This has been on the backlog as a ticket so I don't lose sight of this.

  3. kristapsk commented on Mar 18, 2021

    @kristapsk
    Contributor

    I also don't have Python 3.6 on my laptop anymore, so test/firefox.sh don't work. Also, Python 3.6 has EOL in 9 months (23 Dec 2021).

  4. pinned this issue on Mar 24, 2021
  5. zoracon commented on Mar 29, 2021

    @zoracon
    Contributor

    @kristapsk updated to Python3. If you could test to let me know if the tests work out for you I'd appreciate it!

  6. zoracon commented on Apr 27, 2021

    @zoracon
    Contributor

    Assuming this is not an issue now, closing.

  7. unpinned this issue on Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions