You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Shell scripts, hashbangs and docs require python3.6 #18951
Shell scripts like the test coverage scripts explicitly refer to python3.6, which is increasingly not present on Linux distros which often provide python3.7 or python3.8 now. Also iirc, Python installers for Windows do not provide Python3.6.exe/cmd , and may not even provide a Python3.exe - should re-check that, as Windows users should be able to help with issues like #18745 , and docs saying python3.6 is going to confuse them.
git grep python3.6 has 48 results; very varied.
Suggest using just python3 now, and check the minimum supported version inside the scripts, especially any which dont work on python3.4+ which is a really safe minimum, and provide a useful error message if an insufficient version is installed.
Reacted by pipboy96, Mikhail Kuryshev, CHAN, Chak Shing and Kristaps Kaupe
... which ensures that Firefox builds are deterministic, is derived from the Python 3.6 standard library. We've targeted 3.6 for this reason, as well as to enforce similar tooling across different contributor development environments.
In #6749 (comment), @Hainish explained the rationale behind hard-coding Python 3.6 dependency approximately 2 years ago, which seems unfit for this moment when Python 2.7 is obsolete and Ubuntu 18.04 LTS is released.
We use the bionic release for Travis CI and docker image. I think it is fine to use #!/bin/usr/env python3 as the Ubuntu LTS ships with Python 3.6 by default if the builds remains deterministic. If possible, we proceed with #9993 in the long term.
Activity
cschanaj commentedon Feb 20, 2020
As per https://trac.torproject.org/projects/tor/ticket/29097
In #6749 (comment), @Hainish explained the rationale behind hard-coding Python 3.6 dependency approximately 2 years ago, which seems unfit for this moment when Python 2.7 is obsolete and Ubuntu 18.04 LTS is released.
We use the
bionicrelease for Travis CI and docker image. I think it is fine to use#!/bin/usr/env python3as the Ubuntu LTS ships with Python 3.6 by default if the builds remains deterministic. If possible, we proceed with #9993 in the long term.zoracon commentedon Apr 30, 2020
I have been slowly moving into using Python3 instead. This has been on the backlog as a ticket so I don't lose sight of this.
kristapsk commentedon Mar 18, 2021
I also don't have Python 3.6 on my laptop anymore, so
test/firefox.shdon't work. Also, Python 3.6 has EOL in 9 months (23 Dec 2021).Move to Python 3. Python3.6 causing multiple issues with newer Ubuntu…
Move to Python 3. Python3.6 causing multiple issues with newer Ubuntu…
zoracon commentedon Mar 29, 2021
@kristapsk updated to Python3. If you could test to let me know if the tests work out for you I'd appreciate it!
zoracon commentedon Apr 27, 2021
Assuming this is not an issue now, closing.