Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

For Indeed Open Source Contributors #18745

Closed

Description

@zoracon

Instructions for Indeed Open Source volunteers

Skills needed: minimal knowledge of the command line, a code editor, Git, and Github

Installation

Join chat

Focus: Amending rulesets

Issue: #17912

  • Please take the time to focus on one ruleset at a time. Some rulesets are older and need more than just s3 bucket pruning. Some may need more test urls or host updates. We have tests that run on each PR submission, but there are ways to locally test if your environment set up.
    -- Within the repo, you can test a ruleset file with this command:
    python3.6 test/rules/src/https_everywhere_checker/check_rules.py test/rules/http.checker.config rules/example-file.xml.
    -- This command will run checks against each host and for proper test coverage. Please address error that may appear.

Example of helpful commit: 7b8f315

Activity

  1. added
    EFFSomeone at EFF needs to look into
    on Dec 16, 2019
  2. self-assigned this
    on Dec 16, 2019
  3. zoracon commented on Dec 18, 2019

    @zoracon
    ContributorAuthor

    Example workflow

    1. Run test initially to see which hosts currently have issues
      python3.6 test/rules/src/https_everywhere_checker/check_rules.py test/rules/http.checker.config rules/example-file.xml
    • Some hosts have issues? Take out and leave a comment about the error the hosts gave
    • The main host can't be resolved? The ruleset can be removed entirely, commit and push PR.
    1. Remove any references to s3 buckets.

    2. Update possible missed subdomains with Sublistr tool or dnsdumpster.com.

    3. Run check_rules.py test again to see if any hosts or coverage is needed still.

    4. Repeat test until ruleset checks out and push a PR to the forked repo comparing to the master branch of the EFF/Https-Everywhere repo.

  4. added
    amazon-s3-2020Bare s3.amazonaws.com domain deprecation, see #17912
    on Dec 18, 2019
  5. zoracon commented on Mar 5, 2020

    @zoracon
    ContributorAuthor

    Closing for now since this event has passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

EFFSomeone at EFF needs to look intoamazon-s3-2020Bare s3.amazonaws.com domain deprecation, see #17912

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions