Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Restore counter to disabled by default #12325

Closed

Description

@jsha

We disabled the counter by default in Feb 2016, mainly because it's not informative: It counts rulesets (rather than resources), which is a fairly arbitrary divide since some domain names have many rulesets that potentially apply. It also counts potentially applicable rulesets rather than actually applied rulesets, which means that the extension claims credit on sites it didn't modify at all. Also note that the question "is HTTPS Everywhere potentially active on this site" is independently shown by the icon state: light blue for no applicable rules, dark blue for applicable rules. Though I'll admit that's kinda subtle.

I think the best short-term fix is to go back to hiding by default. Long-term, I think the ideal stat to track would be the number of top-level page navigations upgraded. Since this number would get large over time, it would fit better under the menu than as a notification badge.

Activity

  1. jsha commented on Sep 2, 2017

    @jsha
    MemberAuthor

    No longer. It was removed recently.

    Ah, thanks for the update! Clearly I'm a bit out of touch. :-) Why was it removed?

  2. cschanaj commented on Sep 2, 2017

    @cschanaj
    Collaborator

    mainly because it's not informative: It counts rulesets (rather than resources)

    I agree, how many rulesets applied depend on how a contributor structured the rulesets. It might not be important to the normal user who never contributed to the ruleset base.

    Too confusing.

    Actually, I like the "light blue icon" feature instead of "counter". Mainly because whether the extension rewrite something is a boolean information.

    See also #12308

  3. cschanaj commented on Sep 2, 2017

    @cschanaj
    Collaborator

    I am not sure about how others are using the extensions, but personally I focus more on the web content rather than looking at the behavior of the extensions I have (unless I am a web developer).

  4. cschanaj commented on Sep 2, 2017

    @cschanaj
    Collaborator

    I prefer to have the user to disable the counter manually in such case. As you might know, I am also against configurable color.

    P.S. I wish (at least) the button to disable the counter can be more visible from the popup UI.

  5. cschanaj commented on Sep 2, 2017

    @cschanaj
    Collaborator

    because we might run into a dilemma when the user demand a different "font color", "popup background color" even a different "default icon color". I would like to avoid the potential maintenance overhead.

  6. foobar13373 commented on Sep 2, 2017

    @foobar13373

    For me, the counter checkbox has the same problem like the block-unencrypted checkbox before (which was fixed already):

    The checkbox state is saved between browser sessions, but the actual functionality is reset. If I disable the counter and restart the browser, the checkbox stays disabled, but the counter is there again.

    Cookies disabled (whitelisting via FF per-page settings) and JS disabled via uBlock origin (whitelisting via uBO).

  7. foobar13373 commented on Sep 2, 2017

    @foobar13373

    @koops76
    2017.8.31 - the block unencrypted checkbox is working between browser sessions, but the counter functionality is reset each time (while the checkbox state is saved correctly).

  8. bardiharborow commented on Sep 2, 2017

    @bardiharborow
    Contributor

    While it may or may not serve as an important indicator, it's not a component that needs to be actively drawing user attention. Extension badges are dark grey by default, and there's no compelling reason for an extension to deviate from that unless it's attempting to indicate an abnormal condition, or something else that otherwise deserves user attention.

    I found the green color quite distracting initially as I kept thinking there was some sort of notification. While I've now mostly zoned it out, I find it poor UI design. I'm happy to keep the counter if we can change the color back to dark grey.

  9. foobar13373 commented on Sep 3, 2017

    @foobar13373

    @koops76
    Sorry, was a typo 13 -> 31 - I already have 2017.8.31

  10. patheticcockroach commented on Sep 22, 2017

    @patheticcockroach
    Contributor

    I have version 2017.09.12 and I have the same problem as foobar13373: even though the counter is "disabled" according to the add-on's settings, it still show up, which is pretty distracting...

    The issue is in Firefox 55.0.3. I also use Vivaldi, and there the counter is properly hidden

  11. patheticcockroach commented on Sep 22, 2017

    @patheticcockroach
    Contributor

    Hm, what do you mean the Mozilla bug tracker? Isn't that a place for Firefox's bugs and not extension bugs? (or is there a place there just for HTTPS Everywhere? I can't seem to find it :s)

    Note that I also use Ghostery and uBlock, both know how to hide their counters if I ask them to. Only HTTPS Everywhere has issues

  12. patheticcockroach commented on Sep 22, 2017

    @patheticcockroach
    Contributor
  13. patheticcockroach commented on Sep 22, 2017

    @patheticcockroach
    Contributor

    They already closed it: "Please report the issue to the extension author" :s

  14. patheticcockroach commented on Sep 27, 2017

    @patheticcockroach
    Contributor

    Update on my issue: I found out that it doesn't occur in one of my (rarely used) Fx profiles. Trying to figure out what's making the difference... I already tried disabling all other extensions, so it doesn't seem to be an add-on conflict

    Edit: solved with the latest update

  15. pipboy96 commented on Mar 28, 2019

    @pipboy96
    Contributor

    Since this number would get large over time, it would fit better under the menu than as a notification badge.

    Related: #17068

  16. pipboy96 commented on May 9, 2019

    @pipboy96
    Contributor

    Closed as part of UI rewrite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions