Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

[Firefox] Toolbar icon's new rule count looks too much like a notification #12308

Closed

Description

@Macil

Did HTTPS Everywhere recently have an update affecting the toolbar icon in Firefox? I thought it didn't look like this before tonight. (I just checked against the old version of the Tor Browser Bundle I had laying around, and its version of HTTPS Everywhere didn't have a counter like this in it.)

screenshot from 2017-09-01 01-10-06

About literally every time I change tabs, the number either disappears, appears, or changes and distracts me. It's in about the same area of the screen and vaguely styled similar to how Facebook notifications are shown in Facebook, so I thought there was some notification there for me. The modern web has seriously trained me to click on notification icons like that as soon as possible to hopefully get something interesting or make sure my friend doesn't think I'm ignoring them, and to make the notification go away. It took me a minute of clicking different things in the dropdown menu looking for a notification before I realized the number was just a count of active rules, and that the notification count wasn't going to go away.

I guess I can just remove the toolbar icon, though I love the project and want it to have the best defaults and was curious if anyone else had this problem. Maybe it could default off, be a different color, or have the count have no background? (EDIT: I finally noticed the "Show Counter" option on the Add-ons page. Another possibility is to show that in the dropdown too.)


... Heh, not really related, but if you right-click on the icon, hit customize, and then close the customize tab, then the HTTPS Everywhere toolbar icon's counter turns red until you switch to a different tab. I'm a little amused how right after I mention that I think the icon looks too much like a Facebook notification icon, I find a bug that makes it look even closer to one. I guess I'm just including this screenshot here as an (accidentally realized) example of a possible design that's undeniably close to Facebook notifications, and to possibly emphasize the similarity of HTTPS Everywhere's current design.

screenshot from 2017-09-01 01-16-44

Activity

  1. cschanaj commented on Sep 1, 2017

    @cschanaj
    Collaborator

    I can confirm the issue regarding the counter color turning red on "Customize".

    Not sure if they are going to change the default behavior (or the color), but I agree it is sort of too catchy now. If possible, I prefer the counter to use a less "eye-catching" color. Best if it is consistent with uBlock.

    too catchy now

    P.S. You can disable the counter by "Tool" > "Add-ons", then click the "Perference" button for "HTTPS Everywhere",.uncheck "Show counter"

  2. Bisaloo commented on Sep 1, 2017

    @Bisaloo
    Collaborator

    Maybe it could default off

    +1

    EDIT: I finally noticed the "Show Counter" option on the Add-ons page. Another possibility is to show that in the dropdown too.

    +1


    I agree that it's too catchy right now and a white/grey background may be better but:

  3. Bisaloo commented on Sep 1, 2017

    @Bisaloo
    Collaborator

    Related discussion in #10002.

  4. cschanaj commented on Sep 1, 2017

    @cschanaj
    Collaborator

    I think it should be at least default off if we ain't going to change the color.

    • default is a blue
    • extension is disabled is grey
    • no active ruleset for a website is pale blue (seeming this feature was gone)
    • "Block all unencrypted connection" is red

    IMHO, there is too many information on the icon of the extension and a default on counter add too much information.

    It has the same color as Privacy Badger's badge. Won't fix I guess.

    Our icons have different colors, though.

    I wonder what changes its color to red though. There's no code that changes the color to anything but green in the extension.

    I haven't dig into the UI code at all. sorry.

  5. cschanaj commented on Sep 1, 2017

    @cschanaj
    Collaborator

    @koops76 Personally, I don't recommend configurable colors. It seem unnecessary for a 'privacy' extension which rewrite HTTP to HTTPS. I'd rather it is default off if the color isn't meant to be changed.

  6. cschanaj commented on Sep 1, 2017

    @cschanaj
    Collaborator

    EDIT: I finally noticed the "Show Counter" option on the Add-ons page. Another possibility is to show that in the dropdown too.

    ^ this is a nice feature to have.

  7. cschanaj commented on Sep 1, 2017

    @cschanaj
    Collaborator

    @koops76 Honestly, I cannot judge which color is the best. From #1775, I got the impression a lot of https-everywhere user use uBlock as well. It will be great from my perspective to be consistent with that.

    I'd like to note that I am against adding configurable colors, because it seems a unnecessary feature for an extension of this type. (In particular, Privacy Badger does not have configurable colors).

    If a user find the counter more annoying than useful, they will disable it themselves. The best we can do is to make it convenient to change the setting via the popup UI if changing the default behavior is not an option.

  8. J0WI commented on Oct 30, 2017

    @J0WI
    Contributor

    I think this has been fixed in #12552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions