Repository navigation
Cherry-pick apache/datafusion#25019: ignore constant aggregate completion boundaries - #203
Closed
Tristan1900 wants to merge 1 commit into
Conversation
Tristan1900
force-pushed
the
wenqi.mou/cherry-pick/apache-pr-25072-20261111
branch
from
November 11, 2026 23:00
b49b010 to
a2161fd
Compare
Tristan1900
force-pushed
the
wenqi.mou/cherry-pick/apache-pr-25019-20261111
branch
from
November 11, 2026 23:00
17a947e to
368b632
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## wenqi.mou/cherry-pick/apache-pr-25072-20261111 #203 +/- ##
==================================================================================
- Coverage 81.21% 81.21% -0.01%
==================================================================================
Files 1111 1111
Lines 388447 388527 +80
Branches 388447 388527 +80
==================================================================================
+ Hits 315492 315550 +58
- Misses 54357 54368 +11
- Partials 18598 18609 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Tristan1900
marked this pull request as ready for review
November 12, 2026 18:23
Tristan1900
force-pushed
the
wenqi.mou/cherry-pick/apache-pr-25072-20261111
branch
from
November 12, 2026 18:36
a2161fd to
efed976
Compare
Tristan1900
force-pushed
the
wenqi.mou/cherry-pick/apache-pr-25019-20261111
branch
from
November 12, 2026 18:36
368b632 to
70c3f25
Compare
## Which issue does this PR close? - Closes apache#25018 ## Rationale for this change A grouping column with one fixed value never changes, so it cannot tell aggregation that an earlier group is complete. Currently the logic uses such columns when choosing how aggregation processes its input. This can select the ordered path even when the remaining grouping columns are not ordered. ## What changes are included in this PR? - Ignore fixed grouping columns when deciding when groups can be completed. - Preserve ordered aggregation when all grouping columns that can change are ordered. - Update relevant plans ## What is the testing strategy for this PR? Added tests for a grouping column fixed by a filter. The tests fail without the fix. ## Are there any user-facing changes? No query results or public APIs change. DataFusion now chooses the appropriate aggregation path for fixed grouping columns. (cherry picked from commit 6ff484a)
Tristan1900
force-pushed
the
wenqi.mou/cherry-pick/apache-pr-25072-20261111
branch
from
November 12, 2026 18:56
efed976 to
eda99c6
Compare
Tristan1900
force-pushed
the
wenqi.mou/cherry-pick/apache-pr-25019-20261111
branch
from
November 12, 2026 18:56
70c3f25 to
f056cb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.