Repository navigation
Cherry-pick apache/datafusion#25072: clear ordering for unordered aggregation - #202
Closed
Tristan1900 wants to merge 2 commits into
Closed
Tristan1900 wants to merge 2 commits into
Tristan1900 wants to merge 2 commits into
Conversation
Tristan1900
force-pushed
the
wenqi.mou/cherry-pick/apache-pr-25072-20261111
branch
from
November 11, 2026 23:00
b49b010 to
a2161fd
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## wenqi.mou/cherry-pick/apache-pr-25706-20261112 #202 +/- ##
=================================================================================
Coverage ? 81.21%
=================================================================================
Files ? 1111
Lines ? 388447
Branches ? 388447
=================================================================================
Hits ? 315492
Misses ? 54357
Partials ? 18598 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Tristan1900
marked this pull request as ready for review
November 12, 2026 18:23
Tristan1900
force-pushed
the
wenqi.mou/cherry-pick/apache-pr-25072-20261111
branch
from
November 12, 2026 18:36
a2161fd to
efed976
Compare
Tristan1900
changed the base branch from
branch-55
to
wenqi.mou/cherry-pick/apache-pr-25706-20261112
November 12, 2026 18:37
Grouping sets can change group keys, and partial reduction does not recognize completed groups. Keep both in linear mode before changing how aggregate output ordering is propagated. Port only the aggregate-mode guard from apache#24961; retain DataFusion 55's existing aggregation streams. Partial backport of 5b389eb.
## Which issue does this PR close? N/A ## Rationale for this change Hash Aggregate Partial reduce propagate the ordering of the child even though it does not maintain child ordering ## What changes are included in this PR? clear ordering and test ## What is the testing strategy for this PR? unit test ## Are there any user-facing changes? not really (cherry picked from commit bb7d9f0)
Tristan1900
force-pushed
the
wenqi.mou/cherry-pick/apache-pr-25072-20261111
branch
from
November 12, 2026 18:56
efed976 to
eda99c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PartialReduce, from advertising its input's ordering. Backport apache/datafusion#25072.