Skip to content

Improve sizing behaviour code file view and inspector sidebar splitiview - #287

Merged
lukepistrol merged 3 commits into
CodeEditApp:mainfrom
StefKors:splitview-sizing
Mar 28, 2022
Merged

lukepistrol merged 3 commits into
CodeEditApp:mainfrom
StefKors:splitview-sizing

Conversation

@StefKors

@StefKors StefKors commented Mar 28, 2022 •

Copy link
Copy Markdown
Member

Sets senible minimum frame widths for the WorkspaceCodeFileView and InspectorSidebar. Plus sets a layoutPriority so the splitview resizes correctly.

Description

Before:

Screen.Recording.2022-03-28.at.11.47.17.mov

Releated Issue

I was trying to fix the following issues however they are either outdated or not reproducable:

Checklist (for drafts):

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • Review requested

Screenshots (if appropriate):

After:

Screen.Recording.2022-03-28.at.11.46.42.mov

Comment thread CodeEdit/WorkspaceView.swift Outdated
@StefKors
StefKors requested a review from lukepistrol March 28, 2022 10:41

@lukepistrol lukepistrol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know Xcode uses a minWidth of 150 but it does not handle this very well. For now until the status bar gets support to "shrink" please set the minWidth of the Editor to 500. Then we can merge

Comment thread CodeEdit/WorkspaceView.swift Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants