Skip to content

Project Navigator: fixed yellow color being low contrast in light mode - #265

Merged
lukepistrol merged 2 commits into
CodeEditApp:mainfrom
lukepistrol:sidebar-fixes
Mar 26, 2022
Merged

lukepistrol merged 2 commits into
CodeEditApp:mainfrom
lukepistrol:sidebar-fixes

Conversation

@lukepistrol

@lukepistrol lukepistrol commented Mar 26, 2022 •

Copy link
Copy Markdown
Member

Description

Increased the contrast of the yellow icon color in project navigator in light mode.
(subtle but noticeable, using same color as Xcode uses for *.xib files)

Releated Issue

Checklist (for drafts):

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • Review requested

Screenshots (if appropriate):

Before:
Screen Shot 2022-03-26 at 12 07 04

After:
Screen Shot 2022-03-26 at 12 00 36

@lukepistrol lukepistrol added bug Something isn't working UI This is UI related labels Mar 26, 2022
@lukepistrol lukepistrol linked an issue Mar 26, 2022 that may be closed by this pull request
@lukepistrol lukepistrol changed the title fixed yellow color being low contrast in light mode Project Navigator: fixed yellow color being low contrast in light mode Mar 26, 2022
@lukepistrol
lukepistrol requested a review from 0xWDG March 26, 2022 14:02

@0xWDG 0xWDG left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@lukepistrol
lukepistrol removed the request for review from austincondiff March 26, 2022 14:10
@lukepistrol
lukepistrol merged commit 69682a6 into CodeEditApp:main Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working UI This is UI related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] - Icon problems with light theme

2 participants