Skip to content

[BUG] - Icon problems with light theme #247

Closed

Description

@Angelk90

Describe the bug
As you can see from the image some icons when the theme is in light mode are not seen well.

Screenshots
Schermata 2022-03-25 alle 16 55 08

Desktop (please complete the following information):

  • OS: macOS 12.3
  • Xcode: 13.3

Activity

  1. lukepistrol commented on Mar 25, 2022

    @lukepistrol
    Member

    Yeah noticed this too. We might change it from yellow to another color and ditch yellow all-together.

  2. austincondiff commented on Mar 25, 2022

    @austincondiff
    Collaborator

    image

    Screen Shot 2022-03-25 at 12 51 54 PM

    Looks like they change the yellow shade in light mode (Edit: Not just for yellow, but for all colors). I think I read that the use of a certain variable will do that for you.

  3. Angelk90 commented on Mar 25, 2022

    @Angelk90
    ContributorAuthor

    @austincondiff : What program are you viewing the files with XCode?

  4. austincondiff commented on Mar 25, 2022

    @austincondiff
    Collaborator

    Yes, those screenshots are in Xcode. In light mode the colors are darker, in dark mode the colors are lighter. It makes sense to contrast the background.

  5. Angelk90 commented on Mar 25, 2022

    @Angelk90
    ContributorAuthor

    @austincondiff : Again, this is not so well seen in the case of the light background.

    Schermata 2022-03-25 alle 20 02 50

    Schermata 2022-03-25 alle 20 03 04

  6. austincondiff commented on Mar 25, 2022

    @austincondiff
    Collaborator

    @Angelk90 I pointed this out to @lukepistrol earlier, but selected items should get white icons as shown here in Xcode.
    Screen Shot 2022-03-25 at 2 20 51 PM

  7. Angelk90 commented on Mar 25, 2022

    @Angelk90
    ContributorAuthor

    @austincondiff : Yes, this could be the ideal solution.

  8. self-assigned this
    on Mar 25, 2022
  9. lukepistrol commented on Mar 25, 2022

    @lukepistrol
    Member

    just assigned it to myself

  10. Angelk90 commented on Mar 25, 2022

    @Angelk90
    ContributorAuthor

    @austincondiff : Editor: Agate

    Schermata 2022-03-25 alle 22 39 00

  11. changed the title [-][BUG] - Problem icons with thema light[/-] [+][BUG] - Icon problems with light theme[/+] on Mar 25, 2022
  12. lukepistrol commented on Mar 26, 2022

    @lukepistrol
    Member

    @austincondiff : Again, this is not so well seen in the case of the light background.

    Schermata 2022-03-25 alle 20 02 50 Schermata 2022-03-25 alle 20 03 04

    was fixed in #259

  13. moved this from 🆕 New to 🏁 Complete in CodeEdit Projecton Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions