Repository navigation
Accept shared containers while rejecting reference cycles - #22
Merged
Merged
Conversation
This was referenced Oct 18, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 163 165 +2
=========================================
+ Hits 163 165 +2 ☔ View full report in Codecov by Harness. |
Code0x58
force-pushed
the
codex/accept-shared-json-values
branch
from
October 18, 2026 15:13
b8f621e to
7a65fcd
Compare
Code0x58
force-pushed
the
codex/accept-shared-json-values
branch
7 times, most recently
from
October 18, 2026 18:49
09b398a to
3c8d82b
Compare
Code0x58
force-pushed
the
codex/accept-shared-json-values
branch
from
October 18, 2026 18:50
3c8d82b to
7ae59fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cycle detection now tracks only the active traversal path across dictionaries, lists, and tuples. Reusing the same container in sibling branches is accepted, while actual cycles raise ValueError before changing memory or disk.
Validation: 40 tests and 106 subtests pass, including shared containers, mixed tuple/list cycles, deferred commits, persisted round trips, and post-rejection recovery.
Stack position 9 of 9. Depends on #21; this PR targets
codex/reject-invalid-valuesso its diff contains only this fix. Addresses review finding 4.Stack overview: #14. This is the final PR.