Repository navigation
Reject unsupported values before changing store data - #21
Merged
Merged
Conversation
This was referenced Oct 18, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21 +/- ##
===========================================
+ Coverage 98.77% 100.00% +1.22%
===========================================
Files 1 1
Lines 163 163
===========================================
+ Hits 161 163 +2
+ Misses 2 0 -2 ☔ View full report in Codecov by Harness. |
Code0x58
force-pushed
the
codex/reject-invalid-values
branch
from
October 18, 2026 15:13
b494ae7 to
57dc7b2
Compare
Code0x58
force-pushed
the
codex/reject-invalid-values
branch
6 times, most recently
from
October 18, 2026 15:47
2331a95 to
45bae84
Compare
Code0x58
force-pushed
the
codex/reject-invalid-values
branch
from
October 18, 2026 18:49
45bae84 to
bf87bdc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation raises TypeError for unsupported values before mutation, including when commits are deferred. Both the input and deep-copied result are checked so custom deepcopy methods cannot bypass validation or introduce invalid stored values.
Validation: 38 tests pass, covering root/nested/slice assignments under both auto-commit modes, unchanged memory and disk after rejection, continued saving, and custom deepcopy behavior.
Stack position 8 of 9. Depends on #20; this PR targets
codex/executable-documentationso its diff contains only this fix. Addresses review finding 3.Stack overview: #14. Next: #22.