Skip to content

Persist deletions when automatic commits are enabled - #16

Merged
Code0x58 merged 1 commit into
masterfrom
codex/persist-deletions
Oct 18, 2026
Merged

Code0x58 merged 1 commit into
masterfrom
codex/persist-deletions

Conversation

@Code0x58

@Code0x58 Code0x58 commented Oct 18, 2026 •

Copy link
Copy Markdown
Owner

Attribute and item deletions now save immediately when automatic commits are enabled. Nested dictionary deletions, list indices, and slices follow the same rule; transactions and auto_commit=False still defer writes.

Validation: 24 tests pass, including reopening after each deletion form and checking deferred commits.

Stack position 3 of 9. Depends on #15; this PR targets codex/repair-test-assertions so its diff contains only this fix. Addresses review finding 1.

Stack overview: #14. Next: #17.

@codecov

codecov Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.89%. Comparing base (8cb9ddf) to head (f193652).
⚠️ Report is 9 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   98.77%   95.89%   -2.89%     
==========================================
  Files           1        1              
  Lines         163      146      -17     
==========================================
- Hits          161      140      -21     
- Misses          2        6       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@Code0x58
Code0x58 force-pushed the codex/persist-deletions branch from 8fb4e17 to bd68ffa Compare October 18, 2026 15:13
@Code0x58
Code0x58 added this pull request to stack #23 October 18, 2026 15:39
@Code0x58
Code0x58 force-pushed the codex/persist-deletions branch from bd68ffa to 616ed1a Compare October 18, 2026 15:40
Base automatically changed from codex/repair-test-assertions to master October 18, 2026 15:42
@Code0x58
Code0x58 force-pushed the codex/persist-deletions branch from 616ed1a to f193652 Compare October 18, 2026 15:43
@Code0x58
Code0x58 merged commit 1d4ff24 into master Oct 18, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant