Repository navigation
Persist deletions when automatic commits are enabled - #16
Merged
Merged
Conversation
This was referenced Oct 18, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #16 +/- ##
==========================================
- Coverage 98.77% 95.89% -2.89%
==========================================
Files 1 1
Lines 163 146 -17
==========================================
- Hits 161 140 -21
- Misses 2 6 +4 ☔ View full report in Codecov by Harness. |
Code0x58
force-pushed
the
codex/persist-deletions
branch
from
October 18, 2026 15:13
8fb4e17 to
bd68ffa
Compare
Code0x58
force-pushed
the
codex/persist-deletions
branch
from
October 18, 2026 15:40
bd68ffa to
616ed1a
Compare
Code0x58
force-pushed
the
codex/persist-deletions
branch
from
October 18, 2026 15:43
616ed1a to
f193652
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attribute and item deletions now save immediately when automatic commits are enabled. Nested dictionary deletions, list indices, and slices follow the same rule; transactions and auto_commit=False still defer writes.
Validation: 24 tests pass, including reopening after each deletion form and checking deferred commits.
Stack position 3 of 9. Depends on #15; this PR targets
codex/repair-test-assertionsso its diff contains only this fix. Addresses review finding 1.Stack overview: #14. Next: #17.