Repository navigation
DuckDB (Vortex): build Vortex 0.90.0 on DuckDB 2.0 and update results - #3057
Conversation
|
Results for Logs:
|
|
Results for Logs:
|
|
Results for Logs:
|
|
Results for Logs:
|
|
The run of Logs:
|
Build duckdb-vortex from source for both the single-file and the partitioned variant, pinned to a commit with Vortex 0.90.0 on DuckDB v2.0.0, and add results for c8g.metal-48xl, c7a.metal-48xl and c8g.4xlarge. DuckDB's own `INSTALL vortex` ships an older Vortex, and the partitioned variant was still on v0.44.0. Building against DuckDB 2.0 needs three fixes: link vortex into the shell explicitly (STATICALLY_LINK_EXTENSIONS), skip C++20 module scanning, which needs clang-scan-deps, and raise the open-file limit for many-core hosts. The install script now checks for vortex_version() rather than for the binary, since the plain shell is linked before the extension is built. Rebased onto main after the DuckDB 2.0 bump (ClickHouse#3186): pass -no-agent to the custom binary in load and query for both variants, so the CLI keeps its plain output when run from an AI coding agent. Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UeniBANoYjsc8bCuAtmkMC
a1264e9 to
e4bd111
Compare
neuroalexey
left a comment
There was a problem hiding this comment.
Status: Needs a fix — the new duckdb-vortex results will not show
The rebase brings in main's duckdb-vortex/results/20261110/ (7f7648d). Those runs use the stock DuckDB 2.0 with INSTALL vortex. The website shows only the latest dated copy of each <system>/<machine> pair (README § How To Add a New Result). So duckdb-vortex/results/20261102/c8g.4xlarge.json:3 and the other two 20261102 files stay hidden. After the merge, the site shows numbers that these scripts do not produce.
Please run duckdb-vortex again on this head and add results dated after 20261110. duckdb-vortex-partitioned is fine, because main has nothing newer than 20250806.
At a1264e9, the automated duckdb-vortex runs on c6a.2xlarge and c6a.xlarge gave no results. But duckdb-vortex-partitioned worked on both, with the same install. Is it expected?
I ran main's validator on this head: no errors.
Automated review by neuroalexey
The automated benchmark runs of ClickHouse#3057 produced results for `duckdb-vortex` (5 machines) and `duckdb-vortex-partitioned` (8 machines). They could not be committed to the PR because it comes from an organization-owned fork, so they are added here, and the manually added result files are removed, as the collector does for PRs it can push to. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
duckdb-vortexfrom source for bothduckdb-vortexandduckdb-vortex-partitioned, pinned to vortex-data/duckdb-vortex@59b149b (Vortex 0.90.0 on DuckDB v2.0.0). DuckDB's ownINSTALL vortexships an older Vortex, and the partitioned variant was still on v0.44.0.STATICALLY_LINK_EXTENSIONS), skip C++20 module scanning, which needsclang-scan-deps(CMAKE_CXX_SCAN_FOR_MODULES=OFF), and raise the open-file limit for many-core hosts.installnow checks forvortex_version()rather than for the binary, since the plain shell is linked before the extension is built.