Repository navigation
Bump DuckDB, add -no-agent flag - #3186
Conversation
neuroalexey
left a comment
There was a problem hiding this comment.
duckdb-iceberg/query:13andduckdb-iceberg/load:12: still callduckdbwithout-no-agent, so they get agent-mode output (Markdown tables, progress bar) under the same conditions this PR fixes for the other 6 duckdb dirs. Add the flag there too. (README § "Rules and Contribution": consistent, comparable measurement)- No version pin changes in the diff (installs use
install.duckdb.org"latest"); the "Bump DuckDB" in the title is not visible in the files. Confirm that is intended.
— automated review by neuroalexey (run cron:pr-review:20261109-152139-8ba50cf6)
…bump-duckdbv2.0
`duckdb-iceberg` was added on `main` after this branch was created, and the `json/duckdb` and `json/duckdb-variant` entries parse the CLI output too (`count` expects a bare number), so they need the same flag to keep the plain output when the benchmark is run from an AI coding agent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rtitioned, duckdb-iceberg, duckdb-parquet, duckdb-parquet-partitioned, duckdb-vortex, duckdb-vortex-tuned (c6a.2xlarge, c6a.4xlarge, c6a.large, c6a.metal, c6a.xlarge, c7a.metal-48xl, c8g.4xlarge, c8g.metal-48xl, t3a.small)
|
Results for Logs:
|
…-iceberg (c6a.large, t3a.small)
|
Results for Logs:
|
|
Results for Logs:
|
|
The run of Logs:
|
|
The run of Logs:
|
Build duckdb-vortex from source for both the single-file and the partitioned variant, pinned to a commit with Vortex 0.90.0 on DuckDB v2.0.0, and add results for c8g.metal-48xl, c7a.metal-48xl and c8g.4xlarge. DuckDB's own `INSTALL vortex` ships an older Vortex, and the partitioned variant was still on v0.44.0. Building against DuckDB 2.0 needs three fixes: link vortex into the shell explicitly (STATICALLY_LINK_EXTENSIONS), skip C++20 module scanning, which needs clang-scan-deps, and raise the open-file limit for many-core hosts. The install script now checks for vortex_version() rather than for the binary, since the plain shell is linked before the extension is built. Rebased onto main after the DuckDB 2.0 bump (ClickHouse#3186): pass -no-agent to the custom binary in load and query for both variants, so the CLI keeps its plain output when run from an AI coding agent. Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UeniBANoYjsc8bCuAtmkMC
First time submitting a bump to Clickbench, so I hope I did this all right.
Only thing I changed was add the
-no-agentflag to the commands. I noticed that the DuckDB version wasn't pinned to a specific version, so I didn't do that here either. Please let me know if that's correct :)