Repository navigation
the FOMO card said "#1 on 23 of 11 benchmarks" - #2870
Merged
Merged
Conversation
Two halves of one sentence counting different things. `wins` is one per chain led, deliberately, so a product topping four chain tabs of one bench earns four. `distinctBenchCount` is one per bench. Putting them either side of "of" only worked while the trading benches had no chain axis and a win meant a bench. Seven chain tabs landed on four of those benches this afternoon, in #2846 and #2857. The numerator multiplied, the denominator did not, and the card went out claiming a count that cannot exist. Mine. benchesLedCount counts distinct benchmarks the provider leads in any view, aggregate or chain, which is the basis the sentence already promised. FOMO now reads "#1 on 9 of 10 benchmarks" against 23 and 11. The two other places that use `wins` keep it: they say "first-place finishes", which can honestly exceed the bench count. They now say "first-place finishes across chains", because a reader who sees 23 finishes and 10 benchmarks will divide them and the two words stop that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks #2861 from
dev. This is the second half of what the boss flagged on openchainbench.com/products/fomo: the claim sits in the OpenGraph card, which is why it does not appear in the page HTML.The numerator counted first places per chain and the denominator counted distinct benchmarks, so any provider leading a bench with several chain tabs produced a numerator larger than its own denominator. FOMO leads seven chain tabs on one bench and the card read "#1 on 23 of 11 benchmarks".
benchesLedCountnow counts distinct benchmark slugs where the provider ranks first overall or first on any chain, so both sides of the fraction count the same thing. FOMO reads "9 of 10".Checks
bun test src/464 pass,pnpm validate246 specs,tsc --noEmitclean.🤖 Generated with Claude Code