Repository navigation
the FOMO card said "#1 on 23 of 11 benchmarks" - #2861
Merged
Merged
Conversation
Two halves of one sentence counting different things. `wins` is one per chain led, deliberately, so a product topping four chain tabs of one bench earns four. `distinctBenchCount` is one per bench. Putting them either side of "of" only worked while the trading benches had no chain axis and a win meant a bench. Seven chain tabs landed on four of those benches this afternoon, in #2846 and #2857. The numerator multiplied, the denominator did not, and the card went out claiming a count that cannot exist. Mine. benchesLedCount counts distinct benchmarks the provider leads in any view, aggregate or chain, which is the basis the sentence already promised. FOMO now reads "#1 on 9 of 10 benchmarks" against 23 and 11. The two other places that use `wins` keep it: they say "first-place finishes", which can honestly exceed the bench count. They now say "first-place finishes across chains", because a reader who sees 23 finishes and 10 benchmarks will divide them and the two words stop that.
Flotapponnier
added a commit
that referenced
this pull request
Oct 7, 2026
Two halves of one sentence counting different things. `wins` is one per chain led, deliberately, so a product topping four chain tabs of one bench earns four. `distinctBenchCount` is one per bench. Putting them either side of "of" only worked while the trading benches had no chain axis and a win meant a bench. Seven chain tabs landed on four of those benches this afternoon, in #2846 and #2857. The numerator multiplied, the denominator did not, and the card went out claiming a count that cannot exist. Mine. benchesLedCount counts distinct benchmarks the provider leads in any view, aggregate or chain, which is the basis the sentence already promised. FOMO now reads "#1 on 9 of 10 benchmarks" against 23 and 11. The two other places that use `wins` keep it: they say "first-place finishes", which can honestly exceed the bench count. They now say "first-place finishes across chains", because a reader who sees 23 finishes and 10 benchmarks will divide them and the two words stop that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your boss flagged
/products/fomoas "totally wrong". He is right, and it is mine.The bug
Two halves of one sentence counting different things:
`#1 on ${p.wins} of ${distinctBenchCount(p.appearances)} benchmarks`winsis one per chain led — deliberately, and the code says so: "For benches WITH chain dimensions: 1 win per chain led."distinctBenchCountis one per bench. Putting them either side of "of" only worked while the trading benches had no chain axis and a win meant a bench.Seven chain tabs landed on four of those benches this afternoon, in #2846 and #2857. The numerator multiplied, the denominator did not, and the card went out claiming a count that cannot exist.
The fix
benchesLedCountcounts distinct benchmarks the provider leads in any view, aggregate or chain — the basis the sentence already promised.The two other places that use
winskeep it: they say "first-place finishes", which can honestly exceed the bench count. They now say "first-place finishes across chains", because a reader who sees 23 finishes and 10 benchmarks will divide them, and two words stop that.Not in this PR
The same screenshot carries a second complaint: the /hyperliquid leaderboard is locked to 30D. That is a real gap and a separate change — the harness publishes
_24h_v2,_7d_v2and_30d_v2, butHlBuilderRowonly carries the 30d fields, so the toggle needs the loader and the type widened, not just a control. Scoped, not started.typecheck clean, eslint clean.