Repository navigation
release: chain-aware copy on benches 206 and 207 - #2855
Merged
Merged
Conversation
…2854) #2846 gave 206 and 207 an all-chains default view and #2852 renamed them off the solana- prefix, but the renaming stopped at the title. The body did not move, so both pages shipped to production saying "leads Solana terminals", "routed Solana volume divided by that day's swap count", and, in every one of the eighteen provider formulas, "on Solana on the day". That is a page contradicting its own tab strip in front of readers, on the figure it exists to publish. Fixed across the seo_description, disclaimer, seo_intro, methodology, findings, FAQ and all eighteen formulas. 207's "Is this Solana only?" FAQ was the wrong question once the answer became no; it now answers how to read one chain at a time, which is what someone looking at eight tabs actually wants to know. Three mentions of Solana stay in each, and all three are true: the methodology line about BasedBot routing on Robinhood and almost nothing on Solana, and the tags on Trojan and Photon, which really are Solana-only products. (cherry picked from commit df56c7d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #2854 from dev. The wrong copy is live on production right now.
#2846 gave these two an all-chains default view and #2853 shipped them public, but the body text still said Solana throughout: the seo_description, the disclaimer, the intro, the methodology, the findings, the FAQ and all eighteen provider formulas. Pages contradicting their own tab strip, on the figure they exist to publish.
Three mentions of Solana remain in each and all three are true: BasedBot routing on Robinhood Chain and almost none on Solana, and the Trojan and Photon tags, which really are Solana-only products.
Single commit, applied cleanly with
-x. Nothing else from dev.pnpm validate237/237 — this is a copy-only change, no query, dimension or slug touched, so no worker rebuild is needed before merging and no ordering constraint applies this time.