Skip to content

Support for socksproxytype plugins in Settings dialog - #1547

Merged
g1itch merged 8 commits into
Bitmessage:v0.6from
g1itch:tor
Jan 4, 2020
Merged

Support for socksproxytype plugins in Settings dialog#1547
g1itch merged 8 commits into
Bitmessage:v0.6from
g1itch:tor

Conversation

@g1itch

@g1itch g1itch commented Oct 22, 2019

Copy link
Copy Markdown
Collaborator

Hello.

With this changes now it's possible to set "Proxy server / Tor Type:" to any one provided by plugin. start_proxyconfig will be called when user press "OK" in the Settings dialog.

This is a draft because I'm trying to fix test and maybe port in proxyconfig_stem.

@g1itch g1itch mentioned this pull request Oct 28, 2019
Merged
@g1itch
g1itch force-pushed the tor branch 2 times, most recently from 5235812 to d8c8d2b Compare November 6, 2019 10:53
@dimyme

dimyme commented Nov 10, 2019

Copy link
Copy Markdown
Contributor

it's possible to set "Proxy server / Tor Type:" to any one provided by plugin:

meaning i.e.: proxy_type in SOCKS4a, SOCKS5

any one of these two, choose freely!

@g1itch

g1itch commented Nov 10, 2019

Copy link
Copy Markdown
Collaborator Author

it's possible to set "Proxy server / Tor Type:" to any one provided by plugin:

meaning i.e.: proxy_type in SOCKS4a, SOCKS5

any one of these two, choose freely!

Seriously? tl;dr!

Actually, I meant 'stem' or any other plugin for the bitmessage.proxyconfig entry point. Another silly comment and I'll report abuse.

@g1itch
g1itch force-pushed the tor branch 2 times, most recently from 08e500b to e179d8b Compare November 13, 2019 10:24
PeterSurda
PeterSurda reviewed Nov 16, 2019
View reviewed changes
Comment thread src/helper_startup.py
'bitmessagesettings', 'settingsversion') is None
if not needToCreateKeysFile:
print(
logger.info(

@PeterSurda PeterSurda Nov 16, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, these are the few places where I left print due to initialisation order, which you now fixed.

@g1itch
g1itch force-pushed the tor branch 2 times, most recently from 3d4e108 to ede5b0e Compare December 3, 2019 15:53
@g1itch
g1itch force-pushed the tor branch 2 times, most recently from ff157b1 to fcb1bd5 Compare December 24, 2019 12:38
@g1itch
g1itch marked this pull request as ready for review December 24, 2019 12:39
@g1itch

g1itch commented Dec 24, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

I made this "Ready for review" because it contains the solution for periodic Travis CI fails, e.g. https://travis-ci.org/Bitmessage/PyBitmessage/builds/629056869: I separated clearnet and tor tests and marked tor tests for skipping (because stem package isn't installed).

Manual testing scenario I used for this changeset (and it fails):

  1. on first start select "Let me configure network..." in Connection dialog;
  2. set Proxy server / Tor Type to 'stem';
  3. pybitmessage should connect to the network through tor and start accepting incoming connections;
  4. go back to the network settings and set Proxy server / Tor Type to 'none';
  5. pybitmessage should connect to the network directly using the same port 8444.

PeterSurda
PeterSurda approved these changes Jan 3, 2020
View reviewed changes

@PeterSurda PeterSurda left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested but looks ok.

@g1itch
g1itch merged commit 61f64f7 into Bitmessage:v0.6 Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PeterSurda PeterSurda PeterSurda approved these changes

Assignees

No one assigned

Labels

enhancement New feature usability

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@g1itch @dimyme @PeterSurda