Skip to content

Add "onion services only" or Tor-only networking mode - #1545

Merged
g1itch merged 2 commits into
Bitmessage:v0.6from
sgj3:onionservicesonly
Oct 28, 2019
Merged

g1itch merged 2 commits into
Bitmessage:v0.6from
sgj3:onionservicesonly

Conversation

@sgj3

@sgj3 sgj3 commented Oct 21, 2019

Copy link
Copy Markdown
Contributor

See PR #1540.

…tbound connections to onion services (i.e., hosts that end with '.onion').
@g1itch

g1itch commented Oct 21, 2019

Copy link
Copy Markdown
Collaborator

Apart from the fact that config syntax differs from bitcoin's one (onlynet=<net>) this looks good.

g1itch added a commit to g1itch/PyBitmessage that referenced this pull request Oct 22, 2019
Credit to Dmitri Bogomolov in commit 557a8cc.

@PeterSurda PeterSurda left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

@g1itch

g1itch commented Oct 28, 2019

Copy link
Copy Markdown
Collaborator

Notice also that internal tests (tests.core) are currently broken. I'm still debugging the use of stem inside of the docker. Hope to finish that job in #1547.

@g1itch
g1itch merged commit f871cd4 into Bitmessage:v0.6 Oct 28, 2019
@g1itch

g1itch commented Oct 28, 2019

Copy link
Copy Markdown
Collaborator

Please format commit messages in the next PR's. You can also use first 7 characters of commit hash for reference.

@sgj3
sgj3 deleted the onionservicesonly branch October 28, 2019 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants