Skip to content

Updated Payments > Requesting page - #651

Merged
pavlenex merged 26 commits into
BitcoinDesign:masterfrom
Bosch-0:invoice-patch
Mar 7, 2022
Merged

pavlenex merged 26 commits into
BitcoinDesign:masterfrom
Bosch-0:invoice-patch

Conversation

@Bosch-0

@Bosch-0 Bosch-0 commented Feb 10, 2022 •

Copy link
Copy Markdown
Collaborator

Closes #641
Closes #640
Closes #663
Closes #653

  • Added a lot more detail around adding amounts to payment requests
  • Added a lot more detail around invoice expirations taking heavily from @sbddesign article.
  • Updated some images / other minor copy changes.

Live preview

@Bosch-0 Bosch-0 added Payments Copy Task is about improving text. labels Feb 10, 2022

@GBKS GBKS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good additions, just had some comments. Main thing is that this page is getting really bulky. I'd address this by focusing the page more on UX and less on technical explanations, which can be moved to sub-pages. Better to have a page that makes it easy to parse and get the main steps of the flow, with plenty of options to dig deeper into the parts the reader is interested in.

As mentioned in the comments, I also recommend moving the Home screen image further up, before that design is referenced in the page copy.

I noticed a broken image reference further down the page. Github wouldn't let me add a comment to that line (page too long for the Github review screen). Look for opening-channel@2x.png.png.

There are 464 words on invoice expirations, I think that warrants a dedicated page. Could be a separate PR.

Comment thread guide/payments/request.md Resolved
Comment thread guide/payments/request.md Resolved
Comment thread guide/payments/request.md Resolved
Comment thread guide/payments/request.md Resolved
Comment thread guide/payments/request.md Resolved
Comment thread guide/payments/request.md Resolved
Comment thread guide/payments/request.md Resolved
Comment thread guide/payments/request.md Resolved
Comment thread guide/payments/request.md Resolved
Comment thread guide/payments/request.md Resolved
Bosch-0 and others added 2 commits February 14, 2022 19:09
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>

@pavlenex pavlenex left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great works 🚀 left a few minor comments. Also there's a conflict with cached image that should be resolved.

Comment thread guide/payments/request.md Resolved
Comment thread guide/payments/request.md Resolved
Comment thread guide/payments/request.md

## Withdrawal request

Another way a user can request bitcoin is from a withdrawal request. A withdrawal request is a payment request that lets the receiver withdraw bitcoin from another wallet. Unlike previously mentioned payment requests, withdrawal requests are generated by the sender. These can be useful for merchants providing refunds to customers.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you're requesting bitcoin, rather it's a way to receive it as it's not an action initiated by the received, it's sender that has to create this request for receiver to withdraw, right?

Suggested change
Another way a user can request bitcoin is from a withdrawal request. A withdrawal request is a payment request that lets the receiver withdraw bitcoin from another wallet. Unlike previously mentioned payment requests, withdrawal requests are generated by the sender. These can be useful for merchants providing refunds to customers.
Another way a user can receive bitcoin is from a withdrawal request. A withdrawal request is a payment request that lets the receiver withdraw bitcoin from another wallet. Unlike previously mentioned payment requests, withdrawal requests are generated by the sender. These can be useful for merchants providing refunds to customers.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah very true! Probably having generating on of these should also be covered in the sending section.

I've discussed with @GBKS about also having a Receiving page that covers receiving in more detail (mostly LSP stuff) which we could move this part of the page too also

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are withdrawals only an LNURL thing or will BOLT 12 also make this possible?

In a way, this is initiated by the receiver. Let's say you deposit 100 sats in some Lightning app, take some actions, and then later want to withdraw your balance. Via LNURL-Withdraw, the app can have a static QR code on your profile that lets you withdraw whenever you want. So the sender still has to make the functionality available, but the receiver initiates the actual payment/withdrawal.

Co-authored-by: Pavlenex <pavle@pavle.org>

@GBKS GBKS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update. Just had some minor nitpicks in a few places.

Comment thread guide/payments/request.md Resolved
Comment thread guide/payments/request.md Resolved
Comment thread guide/payments/request.md Resolved
Comment thread guide/payments/request.md Resolved
Comment thread guide/payments/request.md Resolved
Comment thread guide/payments/request.md Resolved
Comment thread guide/payments/request.md Resolved
Comment thread guide/payments/request.md Resolved
Comment thread guide/payments/request.md

## Withdrawal request

Another way a user can request bitcoin is from a withdrawal request. A withdrawal request is a payment request that lets the receiver withdraw bitcoin from another wallet. Unlike previously mentioned payment requests, withdrawal requests are generated by the sender. These can be useful for merchants providing refunds to customers.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are withdrawals only an LNURL thing or will BOLT 12 also make this possible?

In a way, this is initiated by the receiver. Let's say you deposit 100 sats in some Lightning app, take some actions, and then later want to withdraw your balance. Via LNURL-Withdraw, the app can have a static QR code on your profile that lets you withdraw whenever you want. So the sender still has to make the functionality available, but the receiver initiates the actual payment/withdrawal.

Comment thread guide/payments/request.md Resolved
Bosch-0 and others added 13 commits February 21, 2022 18:21
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
@Bosch-0
Bosch-0 requested review from GBKS and pavlenex February 21, 2022 10:52

@sbddesign sbddesign left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, I love the QR code updates.

My main issue is the part about expiries. While I agree with the information, I think it is presented in a way that is a little difficult to parse the context of these payment situations. Also, I appreciate the link to my blog post, but I don't know if that's necessary in this situation. I added a suggested rewrite to address all this.

Comment thread guide/payments/request.md Resolved
Comment thread guide/payments/request.md Resolved
Comment thread guide/payments/request.md Resolved
Comment thread guide/payments/request.md Resolved
Comment thread guide/payments/request.md Resolved
Comment thread guide/payments/request.md Resolved
Comment thread guide/payments/request.md Resolved
Comment thread guide/payments/request.md Resolved
GBKS
GBKS previously approved these changes Feb 23, 2022
Bosch-0 and others added 2 commits March 2, 2022 14:15
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Comment thread guide/payments/request.md Resolved
Comment thread guide/payments/request.md Resolved
@GBKS

GBKS commented Mar 4, 2022

Copy link
Copy Markdown
Contributor

Just did another review. Looks really good.

I think we discussed this before, but the page is really long. We should split out "Receiving bitcoin" to a dedicated page, which would then allow us to go more in-depth on that aspect. Also think we need to do a light revision for consistency once this PR and the one for the Activity page are merged.

@Bosch-0

Bosch-0 commented Mar 5, 2022

Copy link
Copy Markdown
Collaborator Author

We should split out "Receiving bitcoin" to a dedicated page

Yep agree, I'll get the LSP page done and then we can get on to that as I think it'll reference it quite a bit

sbddesign
sbddesign previously approved these changes Mar 5, 2022

@sbddesign sbddesign left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I echo the sentiments that the page is getting kind of long and it might be worth breaking out into subpages. That could be handled in another PR. Open to discussion. But in terms of content, I approve.

@pavlenex pavlenex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, really in-depth and I really like the structure. Agreed with others that we potentially should think about breaking this down into smaller sections, but for now, it looks good to go, LFG 🚀

@pavlenex
pavlenex merged commit 6c60bdc into BitcoinDesign:master Mar 7, 2022
@pavlenex

pavlenex commented Mar 7, 2022

Copy link
Copy Markdown
Contributor

think we discussed this before, but the page is really long. We should split out "Receiving bitcoin" to a dedicated page, which would then allow us to go more in-depth on that aspect. Also think we need to do a light revision for consistency once this PR and the one for the Activity page are merged.

Agreed, now that this and activity page pr are merged, do you want to open up an issue so we can do the cleanup on what's needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Copy Task is about improving text.

Projects

None yet

4 participants