Skip to content

Provide deeper guidance on 0 amount settings for Lightning invoices #641

Closed

Description

@moneyball

Attached is my own personal testing of wallets with 0 amounts. It is a total mess! Muun and Phoenix default to 0 amount, yet most wallets give an error when using them, including Muun!

Hopefully wallets converge on supporting this so this matrix isn’t a mess, but in the mean time the design guide could help a product builder out.

  1. Should a wallet support 0 amount receiving? (I think yes)
  2. Should a wallet default to 0 amount receiving? (I think it depends on use case…but also needs to take into account the current mess of wallet support)
  3. Should a wallet support sending to 0 amount invoices (ie let sender enter amount)? (I think yes, obviously…only reason we’re in this mess is due to an LND security bug that has been fixed but wasn't broadly communicated so the ecosystem is unclear on this)

https://bitcoin.design/guide/payments/request/#amount

image

Activity

  1. self-assigned this
    on Feb 10, 2022
  2. changed the title [-]Provide deeper guidance on amount for LN invoice[/-] [+]Provide deeper guidance on 0 amount settings for Lightning invoices[/+] on Feb 10, 2022
  3. Bosch-0 commented on Feb 11, 2022

    @Bosch-0
    Collaborator

    Also tested on Blixt, you can generate and send 0 amount invoices fine

  4. Bosch-0 commented on Feb 12, 2022

    @Bosch-0
    Collaborator

    Muun allows sending to zero amount invoices on android but not iOS. An issue already existed for this muun/falcon#15

    Breez Issue existed from back in August for generating zero amount invoices, bumped the issue up for better visibility https://github.com/breez/breezmobile/issues/556

  5. Bosch-0 commented on Feb 13, 2022

    @Bosch-0
    Collaborator

    Interesting comment from Breez on this https://github.com/breez/breezmobile/issues/556#issuecomment-1037222108

    Receiving zero amount invoices requires changes to the on-the-fly channel creation infrastructure.

  6. Bosch-0 commented on Feb 14, 2022

    @Bosch-0
    Collaborator

    From tbast at Phoenix: ACINQ/phoenix#248 (comment)

    No, this warning cannot be removed yet.
    We need recipients to implement lightning/bolts#829 to be completely safe.
    Before that, our node, if malicious, could in theory steal the payment, so users should be made aware.

  7. Repository owner moved this from Todo 📝 to Done ✅ in Bitcoin Design Guide Roadmap 🎨🎯on Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

CopyTask is about improving text.

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions