Skip to content

Splits pages from "Getting started" into "Designing Bitcoin products" section - #333

Merged
pavlenex merged 3 commits into
masterfrom
feature/getting-started-split
May 21, 2021
Merged

pavlenex merged 3 commits into
masterfrom
feature/getting-started-split

Conversation

@GBKS

@GBKS GBKS commented May 20, 2021 •

Copy link
Copy Markdown
Contributor

Per #330.

Preview.

Updated all links and image references accordingly.

Please test this first and see how it feels, as it's a bigger architectural change.

Note that this means that there's a new section landing page that we need to write copy for and create a header image.

@GBKS GBKS self-assigned this May 20, 2021
@GBKS GBKS added the Copy Task is about improving text. label May 20, 2021
@GBKS GBKS linked an issue May 20, 2021 that may be closed by this pull request
@Bosch-0

Bosch-0 commented May 20, 2021

Copy link
Copy Markdown
Collaborator

Few things but overall LGTM!

  • Need a link to designing Bitcoin products on introduction page.
  • Link on why Bitcoin is unique still goes to why design for Bitcoin, should go to visual language.
  • Link on visual language still goes to user research, should be Technology primer.
  • Open design still links to visual language, should be user research.
  • User research links to personal finance, should be usage life cycle.
  • Usage life cycle still links to common user flows, should be personal finance.

And added link to the guide landing page.
@GBKS

GBKS commented May 20, 2021

Copy link
Copy Markdown
Contributor Author

@Bosch-0 thanks for the review. I pushed an update with the fixes.

@Bosch-0 Bosch-0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@danielnordh

Copy link
Copy Markdown
Contributor

Looks good.
Would be nice to have a header on the 'Designing Bitcoin products' page: https://deploy-preview-333--sad-borg-390916.netlify.app/guide/designing-products/introduction/

@GBKS

GBKS commented May 21, 2021

Copy link
Copy Markdown
Contributor Author

@danielnordh for sure. Wanna create one? Or an issue for it?

@pavlenex pavlenex left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the section, and tested links and it seems to work OK, so tACK.

Since it's a structural change, I suggest we don't merge it before #302 and transaction privacy, though it shouldn't touch those pages, it's best to leave it out to avoid the possible rebase mess.

Also opened #336 on behalf of @danielnordh just so we don't loose a track of the task.

@GBKS

GBKS commented May 21, 2021

Copy link
Copy Markdown
Contributor Author

@pavlenex the rebase thing is tricky. Obviously don't want to create a big mess for @ConorOkus and @johnsBeharry, but we also have some other structural stuff we want to do after this PR (moving fundamentals pages around). Are we blocking other work from happening if we wait with this one? Maybe best if everyone chimes in.

@pavlenex

Copy link
Copy Markdown
Contributor

@GBKS If other work depends on it, let's mege it, I don't think the work on those two PR's depends on it. I'll take care of the rebases for people if there are problems.

@pavlenex
pavlenex merged commit eac5e80 into master May 21, 2021
@pavlenex

Copy link
Copy Markdown
Contributor

OK confirming there are no issues with the PR's in question after the merge, let's go 🚀

@danielnordh
danielnordh deleted the feature/getting-started-split branch September 17, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Copy Task is about improving text.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split "Getting started" in two sections?

4 participants