Repository navigation
Splits pages from "Getting started" into "Designing Bitcoin products" section - #333
Conversation
…ducts" section Per #330 .
|
Few things but overall LGTM!
|
And added link to the guide landing page.
|
@Bosch-0 thanks for the review. I pushed an update with the fixes. |
|
Looks good. |
|
@danielnordh for sure. Wanna create one? Or an issue for it? |
There was a problem hiding this comment.
I've reviewed the section, and tested links and it seems to work OK, so tACK.
Since it's a structural change, I suggest we don't merge it before #302 and transaction privacy, though it shouldn't touch those pages, it's best to leave it out to avoid the possible rebase mess.
Also opened #336 on behalf of @danielnordh just so we don't loose a track of the task.
|
@pavlenex the rebase thing is tricky. Obviously don't want to create a big mess for @ConorOkus and @johnsBeharry, but we also have some other structural stuff we want to do after this PR (moving fundamentals pages around). Are we blocking other work from happening if we wait with this one? Maybe best if everyone chimes in. |
|
@GBKS If other work depends on it, let's mege it, I don't think the work on those two PR's depends on it. I'll take care of the rebases for people if there are problems. |
|
OK confirming there are no issues with the PR's in question after the merge, let's go 🚀 |
Per #330.
Preview.
Updated all links and image references accordingly.
Please test this first and see how it feels, as it's a bigger architectural change.
Note that this means that there's a new section landing page that we need to write copy for and create a header image.