Skip to content

Add header image to the Designing Bitcoin products page #336

Closed

Description

@pavlenex

As requested by @danielnordh

This issue is for creating a visual header image for the upcoming Designing Bitcoin products page.

This page will appear in the guide after #333 is merged. In the meantime here's a preview of that page.

Activity

  1. mau211 commented on May 24, 2021

    @mau211

    I would like to take this up. Is this both designing and adding it to Designing Bitcoin products page.

  2. GBKS commented on May 25, 2021

    @GBKS
    Contributor

    @mau211 awesome. The first step is the design part. If you'd then like some help with implementing it, we're here to help.

  3. pavlenex commented on May 25, 2021

    @pavlenex
    ContributorAuthor

    Awesome @mau211 it's all yours, looking forward to what you come up with, feel free to share it here or on our Slack 🚀

  4. mau211 commented on May 25, 2021

    @mau211

    Do you have sizing specs for the header and/or design guidelines?
    Also what is the timeline for delivery for this?

  5. pavlenex commented on May 25, 2021

    @pavlenex
    ContributorAuthor

    @mau211 yeah check this out. There are no visual guidelines, we encourage creativity and diversity and artistic freedom when it comes to that. So feel free to get your creative juices flowing.

    If you need an example of a pull request you can do check it in #344. As for the time frame, no strict deadlines on this one, though if you can get it in in the next 5 days that would be awesome, so we can include it in the v1 of the guide which we intend to launch early next month.

  6. GBKS commented on May 26, 2021

    @GBKS
    Contributor

    I keep all the headers I've created in this Figma file, maybe it's of interest. Here's another Figma file with screenshots of all pages, also helps to get an idea of the variety of illustrations that have been done already.

  7. sbddesign commented on Jun 1, 2021

    @sbddesign
    Collaborator

    @mau211 Just checking in. We are hoping to have in image for this page for our Guide launch this week. I can create a header for this page, but I wanted to see if you had something in-progress since you expressed interest in taking on this issue. 🙂

  8. mau211 commented on Jun 1, 2021

    @mau211

    @mau211 Just checking in. We are hoping to have in image for this page for our Guide launch this week. I can create a header for this page, but I wanted to see if you had something in-progress since you expressed interest in taking on this issue. 🙂

    @sbddesign yes I can post my progress here later today :) in the evening.

  9. mau211 commented on Jun 2, 2021

    @mau211

    designingBitcoinProducts_header_WEB

  10. mau211 commented on Jun 2, 2021

    @mau211

    I have a 1600 px for desktop and 400 px for mobile.

  11. mau211 commented on Jun 2, 2021

    @mau211

    What is the next step?

  12. pavlenex commented on Jun 2, 2021

    @pavlenex
    ContributorAuthor

    @mau211 The next step is to do a pull request for it 😄
    I already mentioned how to do it here, but if you need any help join our slack and ping me or @ConorOkus to help you with implementation.

  13. mau211 commented on Jun 3, 2021

    @mau211

    Excited 🥳 😊

  14. pavlenex commented on Jun 3, 2021

    @pavlenex
    ContributorAuthor

    Closed in #369 thanks to @mau211 🎉

  15. GBKS commented on Jun 3, 2021

    @GBKS
    Contributor

    @mau211 thanks for the contribution. Quick heads up that the images are not the right sizes, the alt text should be updated to describe the image content, and layout = "full-width" is added 4 times on the include (once is enough). I can create a PR tomorrow to fix things up.

  16. mau211 commented on Jun 9, 2021

    @mau211

    @mau211 thanks for the contribution. Quick heads up that the images are not the right sizes, the alt text should be updated to describe the image content, and layout = "full-width" is added 4 times on the include (once is enough). I can create a PR tomorrow to fix things up.

    @GBKS , the image widths were followed via the guidelines. Curious, was it the height or resolution that was not accurate?
    Sorry, for the late reply I was on vacation.

  17. GBKS commented on Jun 10, 2021

    @GBKS
    Contributor

    @mau211 no worries. If you look at the 2x desktop version of the image (source is here), the image is 6667x2501, while it should have been 3200x1201 (the width is really the main restriction and image height can be flexible based on the design). Could you let me know which guidelines you followed? Maybe there's incorrect information somewhere.

  18. mau211 commented on Jun 10, 2021

    @mau211

    @mau211 no worries. If you look at the 2x desktop version of the image (source is here), the image is 6667x2501, while it should have been 3200x1201 (the width is really the main restriction and image height can be flexible based on the design). Could you let me know which guidelines you followed? Maybe there's incorrect information somewhere.

    @GBKS https://bitcoin.design/guide/contribute/illustration-guidelines/ There should be both with and height details as well as resolution. Let me know if you need assistance updating this info. Also I could resize the images I sent previously once I get all the dimensions as its really an illustration before exporting it to a png. I followed the width guidelines outlined in above url.
    Below are sizes for the artwork.
    Web 1600x800
    Mobile 400x250
    Desktop 2x 3200x12
    Mobile2x800x600
    Preview 1280x640

    This is the file I uploaded for web2x it is 3200x1200 with resolution of 150.
    Screen Shot 2021-06-10 at 11 16 26 AM

    Maybe it was my export settings.
    The resolution needed to be 72 dpi.
    I have updated all the images to be exported at 72 dpi. I can open a new pr to add them or I can slack them to you. However you would prefer.

  19. GBKS commented on Jun 11, 2021

    @GBKS
    Contributor

    Thank you for double-checking. I already submitted a PR to address the size changes. The PR is here, and the changes are live on the site. Hope that's OK, please take a look and let me know if there are any changes you'd like to make.

    Yes, it maybe have been the DPI setting. DPI is a print-only thing, I am not sure why Adobe products still make it a default thing for exports in digital use. I've been creating my illustrations in Figma primarily, as I find Illustrator et al overly complex in many ways (like the export settings with 500 options).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

DesignTask is about designing something.Good first issueGood for newcomers

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions